Differential D14814

[blob][lib][keyserver] Handle offensive invite link error
ClosedPublic
Actions

Authored by bartek on Jun 6 2025, 7:55 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

tomek
kamil

Commits

rCOMMa6ff8dbc8133: [blob][lib][keyserver] Handle offensive invite link error

Summary

Fix for ENG-10819.
Updated Blob Service to return specific error message when offensive link is caught and handled the error in keyserver invite-link-creator

Depends on D14813

Test Plan

Tested with local keyserver and blob service:

Created profane invite link - it was rejected by keyserver JS check
Commented-out the JS check. The link was correctly rejected by Blob Service and then by the check added in this diff.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jun 6 2025, 7:55 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJun 6 2025, 7:55 AM

Rebase

Harbormaster completed remote builds in B34371: Diff 48434.Jun 6 2025, 8:23 AM

Harbormaster completed remote builds in B34372: Diff 48435.Jun 6 2025, 8:28 AM

bartek published this revision for review.Jun 6 2025, 8:51 AM

tomek accepted this revision.Jun 9 2025, 8:25 AM

This revision is now accepted and ready to land.Jun 9 2025, 8:25 AM

Closed by commit rCOMMa6ff8dbc8133: [blob][lib][keyserver] Handle offensive invite link error. · Explain WhyJun 9 2025, 12:01 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMa6ff8dbc8133: [blob][lib][keyserver] Handle offensive invite link error.

bartek mentioned this in D14821: [terraform] Deploy Blob and Backup to staging.Jun 9 2025, 2:12 PM

bartek mentioned this in rCOMM4a7e7cafc1c7: [terraform] Deploy Blob and Backup to staging.Jun 9 2025, 2:28 PM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

invite-link-creator.js

2 lines

lib/

utils/

blob-service.js

25 lines

services/

blob/

src/

http/

14 lines

Diff 48452

keyserver/src/creators/invite-link-creator.js

Loading...

lib/utils/blob-service.js

Loading...

services/blob/src/http/errors.rs

Loading...