Details
It's really hard to test everything here; for now, only Flow. In the final diff of the stack, I am going to do some more testing by testing core functionalities of threads and messages (including local and media messages).
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/ops/message-store-ops.js | ||
|---|---|---|
| 255 ↗ | (On Diff #48456) | I am using this instead of RawThreadInfo because this is the type used in freshMessageStore |
| 261 ↗ | (On Diff #48456) | When we're unable to decide it is safer to put this data into backup |
| native/redux/unshim-utils.js | ||
| 30 ↗ | (On Diff #48456) | We need it to be able to decide if data should be in backup or no |
| web/redux/unshim-utils.js | ||
| 45–47 ↗ | (On Diff #48456) | getClientDBStore is a wrapper around scheduling GET_CLIENT_STORE, if we use that we don't have to excplictly convert threads here |
| lib/ops/message-store-ops.js | ||
|---|---|---|
| 34 ↗ | (On Diff #48456) | should be read-only |
| web/redux/unshim-utils.js | ||
|---|---|---|
| 45–47 ↗ | (On Diff #48456) | The problem with this solution is that now these utils need to understand that we have multiple DBs. It would be better if we could hide this detail from them. |
| web/redux/unshim-utils.js | ||
|---|---|---|
| 45–47 ↗ | (On Diff #48456) | We can always convert getClientDBStore param to be the default with databaseIdentifier.MAIN, but this is a tradeoff, with this approach it is most likely to not take multiple databases into consideration |