Differential D14837

[native] Rename C++ functions for logs
ClosedPublic
Actions

Authored by bartek on Jun 12 2025, 12:58 PM.

Details

Reviewers

kamil

Commits

rCOMM3353a7852367: [native] Rename C++ functions for logs

Summary

Previous names were confusing, these functions create only single log from last DB activity.

Depends on D14834

Test Plan

native build

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jun 12 2025, 12:58 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 12 2025, 12:58 PM

bartek added a child revision: D14838: [native] Improve logs monitoring management.Jun 12 2025, 1:04 PM

Harbormaster completed remote builds in B34405: Diff 48485.Jun 12 2025, 1:17 PM

bartek published this revision for review.Jun 12 2025, 2:51 PM

kamil accepted this revision.Jun 18 2025, 2:25 PM

This revision is now accepted and ready to land.Jun 18 2025, 2:25 PM

Closed by commit rCOMM3353a7852367: [native] Rename C++ functions for logs. · Explain WhyJul 2 2025, 10:14 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM3353a7852367: [native] Rename C++ functions for logs.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

DatabaseManager.h

2 lines

DatabaseManager.cpp

4 lines

NativeSQLiteConnectionManager.h

2 lines

NativeSQLiteConnectionManager.cpp

2 lines

NativeModules/

CommCoreModule.cpp

2 lines

PersistentStorageUtilities/

DataStores/

BaseDataStore.h

2 lines

Diff 48607

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.h

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.cpp

View Options

native/cpp/CommonCpp/DatabaseManagers/NativeSQLiteConnectionManager.h

View Options

native/cpp/CommonCpp/DatabaseManagers/NativeSQLiteConnectionManager.cpp

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/BaseDataStore.h

[native] Rename C++ functions for logsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48607

native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.h

native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.cpp

native/cpp/CommonCpp/DatabaseManagers/NativeSQLiteConnectionManager.h

native/cpp/CommonCpp/DatabaseManagers/NativeSQLiteConnectionManager.cpp

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/BaseDataStore.h

[native] Rename C++ functions for logs
ClosedPublic
Actions

Revision Contents
Changeset List