[SQLite] update rekeying queries to support backup tables
ClosedPublic
Actions

Authored by kamil on Jun 16 2025, 11:37 AM.

Details

Reviewers

tomek
bartek

Commits

rCOMM90e17829786d: [SQLite] update rekeying queries to support backup tables

Summary

ENG-10851.

We can run this query regardless of type, it will rekey in table where entity exists.

Depends on D14844

Test Plan

Tests in D14848

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jun 16 2025, 11:37 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJun 16 2025, 11:37 AM

kamil added a child revision: D14846: [SQLite] update `SELECT *` queries to support backup tables.Jun 16 2025, 11:38 AM

kamil edited the test plan for this revision. (Show Details)Jun 16 2025, 11:45 AM

Harbormaster failed remote builds in B34420: Diff 48513!Jun 16 2025, 11:50 AM

kamil published this revision for review.Jun 16 2025, 12:33 PM

kamil planned changes to this revision.Jun 16 2025, 2:56 PM

kamil requested review of this revision.Jun 17 2025, 1:01 PM

Harbormaster completed remote builds in B34420: Diff 48513.Jun 17 2025, 1:33 PM

tomek accepted this revision.Jun 18 2025, 10:15 AM

tomek added inline comments.

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
416–426 ↗	(On Diff #48513)	We can consider doing it in a loop.

This revision is now accepted and ready to land.Jun 18 2025, 10:15 AM

address review

Harbormaster completed remote builds in B34448: Diff 48543.Jun 23 2025, 3:38 PM

Closed by commit rCOMM90e17829786d: [SQLite] update rekeying queries to support backup tables. · Explain WhyJun 23 2025, 4:22 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM90e17829786d: [SQLite] update rekeying queries to support backup tables.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

SQLiteQueryExecutor.cpp

22 lines

web/

shared-worker/

_generated/

comm_query_executor.wasm

Diff 48543

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp