Paths

Table of Contentst

[SQLite] update `fetchMessages` to support regular and backup tables
ClosedPublic
Actions

Authored by kamil on Jun 17 2025, 2:20 PM.

Details

Reviewers

tomek
bartek

Commits

rCOMM027decf60462: [SQLite] update `fetchMessages` to support regular and backup tables

Summary

ENG-10857.

Depends on D14854

Test Plan

Tests and experiments with EXPLAIN QUERY PLAN to check if indexes are used and performance is not worse

Diff Detail

Repository

rCOMM Comm

Branch

land

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jun 17 2025, 2:20 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJun 17 2025, 2:20 PM

Harbormaster completed remote builds in B34435: Diff 48528.Jun 17 2025, 3:02 PM

kamil published this revision for review.Jun 18 2025, 8:25 AM

kamil added a child revision: D14856: [SQLite] update `getRelatedMessages` to support regular and backup tables.Jun 18 2025, 9:14 AM

tomek accepted this revision.Jun 23 2025, 11:33 AM

tomek added inline comments.

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
260 ↗	(On Diff #48528)	We should sort the whole result, not only the second select

This revision is now accepted and ready to land.Jun 23 2025, 11:33 AM

kamil added inline comments.Jun 23 2025, 3:28 PM

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
260 ↗	(On Diff #48528)	In SQLite, the `ORDER BY` is applied to the complete result set when using `UNION`

rebase

Harbormaster completed remote builds in B34452: Diff 48547.Jun 23 2025, 3:50 PM

Closed by commit rCOMM027decf60462: [SQLite] update `fetchMessages` to support regular and backup tables. · Explain WhyJun 23 2025, 4:22 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM027decf60462: [SQLite] update `fetchMessages` to support regular and backup tables.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

SQLiteQueryExecutor.cpp

23 lines

web/

shared-worker/

_generated/

comm_query_executor.wasm

queries/

fetch-messages-queries.test.js

101 lines

Diff 48547

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

View Options

web/shared-worker/_generated/comm_query_executor.wasm

View Options

web/shared-worker/queries/fetch-messages-queries.test.js

[SQLite] update `fetchMessages` to support regular and backup tablesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48547

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

web/shared-worker/_generated/comm_query_executor.wasm

web/shared-worker/queries/fetch-messages-queries.test.js

[SQLite] update `fetchMessages` to support regular and backup tables
ClosedPublic
Actions

Revision Contents
Changeset List