Paths

Table of Contentst

Differential D14856

[SQLite] update `getRelatedMessages` to support regular and backup tables
ClosedPublic
Actions

Authored by kamil on Jun 18 2025, 9:14 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

tomek
bartek

Commits

rCOMMa663f7b7512c: [SQLite] update `getRelatedMessages` to support regular and backup tables

Summary

Depends on D14855

Test Plan

Experiments with EXPLAIN QUERY PLAN to check if indexes are used and performance is not worse. I decide to not update test because it'll be redundant. Instead, what I did is go to get-related-messages.test.js (added in D14835) and updated temporary flag (added in D14847) to add messages to the backup tables and run tests again.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jun 18 2025, 9:14 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJun 18 2025, 9:14 AM

Harbormaster completed remote builds in B34436: Diff 48530.Jun 18 2025, 9:36 AM

kamil published this revision for review.Jun 18 2025, 9:37 AM

kamil added a child revision: D14857: [native] implement `threadIDMatchesProtocol` in C++.Jun 18 2025, 11:09 AM

tomek accepted this revision.Jun 23 2025, 11:42 AM

tomek added inline comments.

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
1561 ↗	(On Diff #48530)	We have to make sure that the whole result is sorted

This revision is now accepted and ready to land.Jun 23 2025, 11:42 AM

kamil added inline comments.Jun 23 2025, 3:30 PM

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
1561 ↗	(On Diff #48530)	In SQLite, the `ORDER BY` is applied to the complete result set when using `UNION`

rebase

Harbormaster completed remote builds in B34453: Diff 48548.Jun 23 2025, 3:59 PM

Closed by commit rCOMMa663f7b7512c: [SQLite] update `getRelatedMessages` to support regular and backup tables. · Explain WhyJun 23 2025, 4:22 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMa663f7b7512c: [SQLite] update `getRelatedMessages` to support regular and backup tables.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

SQLiteQueryExecutor.cpp

19 lines

web/

shared-worker/

_generated/

comm_query_executor.wasm

Diff 48561

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...

web/shared-worker/_generated/comm_query_executor.wasm

Loading...