Details
Details
Opened Redux DevTools, restored account and created UserData backup, verified that the store is updated.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/reducers/backup-reducer.js | ||
|---|---|---|
| 46–50 | I am afraid this is an edge case where this could interfere with D14883 without addressing my comment (https://phab.comm.dev/D14883#inline-81395) | |
| lib/reducers/backup-reducer.js | ||
|---|---|---|
| 39 | I am wondering, maybe we should add one more condition, and when fullBackupSupport is not set, just return store? Some actions, such as createUserKeysBackupActionTypes, are currently used in production, which means we'll set some values in the store now. Later, when developing and wanting to change something, we might need to introduce migration, which could slow us down. Adding this will be still fine for testing and could avoid some additional work for us | |
Comment Actions
- Added fullBackupSupport guard
- Separated invariant condition for restoreUserActionTypes