Differential D14904
[tunnelbroker] Increase a heartbeat timeout Authored by tomek on Jul 9 2025, 11:51 AM. Tags None Referenced Files
Subscribers
Details
It may happen that a client is occupied, and it takes it more time to respond to a heartbeat. This may happen e.g., when a longer job is scheduled on the event loop. Bumping this more might be dangerous because of the client timeout https://github.com/CommE2E/comm/blob/6c9b95cac16ea755b04b91b9bcd0537fddfe33b3/lib/shared/timeouts.js#L42. https://linear.app/comm/issue/ENG-10975/increase-tunnelbroker-heartbeat-timeout Added some console logs to verify that the heartbeats are sent less frequently.
Diff Detail
Event TimelineComment Actions I was thinking of even 10s (or 9 to be equal with the client value) but 6s should be enough too Comment Actions Yeah, I was considering that too, but having a margin between these values feels safer. |