Details

Reviewers

kamil
bartek

Commits

rCOMMe77cd2b8ab71: [native][web] Expose linking the account through gRPC

Summary

Depends on D14922

Test Plan

Tested in combination with the rest of the stack. Checked if linking during registration and from the profile screen works.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Jul 14 2025, 4:11 PM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 14 2025, 4:11 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 14 2025, 4:30 PM

Harbormaster failed remote builds in B34555: Diff 48718!

Update native-rust-library

Update CommRustModule

Harbormaster failed remote builds in B34558: Diff 48723!Jul 15 2025, 11:54 AM

Harbormaster completed remote builds in B34559: Diff 48724.Jul 15 2025, 12:11 PM

tomek requested review of this revision.Jul 15 2025, 12:11 PM

bartek added inline comments.Jul 15 2025, 1:14 PM

web/protobufs/identity-auth-client.cjs.flow
167 ↗	(On Diff #48724)	We have a convention of updating `web/protobufs/*` in the same diff as the `.proto` changes.

Rename

Harbormaster completed remote builds in B34563: Diff 48729.Jul 15 2025, 3:09 PM

Harbormaster completed remote builds in B34564: Diff 48730.Jul 15 2025, 3:19 PM

tomek added a child revision: D14931: [lib] Add info about DCs token into Identity.Jul 15 2025, 3:45 PM

NOTE: This diff contains grpc-web changes for D14922's proto changes. For reference, I mentioned it in the other diff as well.

This revision is now accepted and ready to land.Jul 18 2025, 4:08 PM

bartek mentioned this in D14922: [identity] Allow linking Farcaster DCs.Jul 18 2025, 4:10 PM

tomek edited the test plan for this revision. (Show Details)Jul 25 2025, 10:06 AM

Rebase

Harbormaster completed remote builds in B34987: Diff 49194.Jul 25 2025, 10:27 AM

Closed by commit rCOMMe77cd2b8ab71: [native][web] Expose linking the account through gRPC. · Explain WhyJul 25 2025, 5:13 PM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMe77cd2b8ab71: [native][web] Expose linking the account through gRPC.

[native][web] Expose linking the account through gRPC
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 49208

lib/types/identity-service-types.js

native/cpp/CommonCpp/NativeModules/CommRustModule.h

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

native/cpp/CommonCpp/_generated/rustJSI.h

native/identity-service/identity-service-context-provider.react.js

native/native_rust_library/src/identity/farcaster.rs

native/native_rust_library/src/lib.rs

native/schema/CommRustModuleSchema.js

web/grpc/identity-service-client-wrapper.js

web/grpc/identity-service-context-provider.react.js

web/protobufs/identity-auth-client.cjs

web/protobufs/identity-auth-client.cjs.flow

web/protobufs/identity-auth-structs.cjs

web/protobufs/identity-auth-structs.cjs.flow

web/protobufs/identity-unauth-structs.cjs

web/protobufs/identity-unauth-structs.cjs.flow

[native][web] Expose linking the account through gRPCClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49208

lib/types/identity-service-types.js

native/cpp/CommonCpp/NativeModules/CommRustModule.h

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

native/cpp/CommonCpp/_generated/rustJSI.h

native/identity-service/identity-service-context-provider.react.js

native/native_rust_library/src/identity/farcaster.rs

native/native_rust_library/src/lib.rs

native/schema/CommRustModuleSchema.js

web/grpc/identity-service-client-wrapper.js

web/grpc/identity-service-context-provider.react.js

web/protobufs/identity-auth-client.cjs

web/protobufs/identity-auth-client.cjs.flow

web/protobufs/identity-auth-structs.cjs

web/protobufs/identity-auth-structs.cjs.flow

web/protobufs/identity-unauth-structs.cjs

web/protobufs/identity-unauth-structs.cjs.flow

[native][web] Expose linking the account through gRPC
ClosedPublic
Actions

Revision Contents
Changeset List