Paths

Table of Contentst

Differential D14985

[lib][native][web] make `useUserDataRestore` call to be part of context
ClosedPublic
Actions

Authored by kamil on Jul 21 2025, 2:24 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

bartek
tomek

Commits

rCOMM96de8d2e05d3: [lib][native][web] make `useUserDataRestore` call to be part of context

Summary

Test Plan

Test restore on web and native

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jul 21 2025, 2:24 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 21 2025, 2:24 PM

Harbormaster completed remote builds in B34636: Diff 48835.Jul 21 2025, 2:46 PM

kamil published this revision for review.Jul 21 2025, 2:56 PM

kamil added inline comments.

lib/backup/use-user-data-restore.js
78	I can also move the implementation to `UserDataRestoreProvider` - not sure which is better
lib/components/secondary-device-qr-auth-context-provider.react.js
191	It looks like this because I did it using my IDE, I can update if this looks weird
web/app.react.js
580	It has to be here because it is used by `PeerToPeerMessageHandler`, which is part of `TunnelbrokerProvider`

tomek accepted this revision.Jul 22 2025, 8:42 AM

tomek added inline comments.

lib/backup/use-user-data-restore.js
78	Moving it there avoids the need for it to be exported, so devs can't use it incorrectly
lib/components/secondary-device-qr-auth-context-provider.react.js
191	I guess it might be worth making the naming of the methods consistent through this diff

This revision is now accepted and ready to land.Jul 22 2025, 8:42 AM

address review

Harbormaster completed remote builds in B34684: Diff 48886.Jul 22 2025, 10:03 AM

Closed by commit rCOMM96de8d2e05d3: [lib][native][web] make `useUserDataRestore` call to be part of context. · Explain WhyJul 22 2025, 10:08 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM96de8d2e05d3: [lib][native][web] make `useUserDataRestore` call to be part of context.

Revision Contents
Changeset List

Path

Size

lib/

backup/

use-user-data-restore.js

1 line

user-data-restore-context.js

74 lines

components/

secondary-device-qr-auth-context-provider.react.js

4 lines

handlers/

restore-backup-handler.react.js

8 lines

tunnelbroker/

use-peer-to-peer-message-handler.js

4 lines

native/

account/

4 lines

159 lines

web/

67 lines

Diff 48835

lib/backup/use-user-data-restore.js

Loading...

lib/backup/user-data-restore-context.js

Loading...

lib/components/secondary-device-qr-auth-context-provider.react.js

Loading...

lib/handlers/restore-backup-handler.react.js

Loading...

lib/tunnelbroker/use-peer-to-peer-message-handler.js

Loading...

native/account/restore.js

Loading...

native/root.react.js

Loading...

web/app.react.js

Loading...