Paths

Table of Contentst

Differential D15156

[lib] refactor QueuedDMOperations reducer to ops pattern
ClosedPublic
Actions

Authored by kamil on Jul 29 2025, 12:12 PM.

Tags

None

Referenced Files

	F32162131: D15156.1765044634.diff
	Fri, Dec 5, 6:10 PM

	F32160919: D15156.1765041958.diff
	Fri, Dec 5, 5:25 PM

Subscribers

Details

Reviewers

Commits

rCOMMaf21d9a43ecf: [lib] refactor QueuedDMOperations reducer to ops pattern

Summary

ENG-10712 and ENG-11022

Depends on D15155

Test Plan

Tests from D15151

Diff Detail

Repository

Branch

land-que

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jul 29 2025, 12:12 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 29 2025, 12:12 PM

kamil added a child revision: D15157: [native] implement C++ ops for QueuedDMOperations.Jul 29 2025, 12:14 PM

Harbormaster completed remote builds in B35026: Diff 49248.Jul 29 2025, 12:34 PM

kamil edited the summary of this revision. (Show Details)Jul 29 2025, 1:12 PM

kamil published this revision for review.Jul 29 2025, 1:15 PM

kamil edited the test plan for this revision. (Show Details)

kamil added inline comments.

lib/reducers/dm-operations-queue-reducer.js
80–94 ↗	(On Diff #49248)	Previously it wasn't using `processStoreOperations`
lib/shared/unshim-utils.js
91–101 ↗	(On Diff #49248)	Without this, we can't blacklist `queuedDMOperations` because `shimmedOperations` field is still used in `redux-persist` to attempt processing unshimed operations, with this change, it is moved fully to SQLite.

tomek accepted this revision.Jul 30 2025, 1:41 PM

tomek added inline comments.

lib/reducers/dm-operations-queue-reducer.js
53–56 ↗	(On Diff #49248)	This comment can be improved by explaining what it explains. In this case, we're returning the store without modifying it.
lib/shared/unshim-utils.js
95–97 ↗	(On Diff #49248)	I don't fully understand this comment.

This revision is now accepted and ready to land.Jul 30 2025, 1:41 PM

update comments

kamil mentioned this in D15160: [web][native] migrate QueuedDMOperations to SQLite.Jul 30 2025, 3:37 PM

Harbormaster completed remote builds in B35038: Diff 49261.Jul 30 2025, 3:47 PM

Closed by commit rCOMMaf21d9a43ecf: [lib] refactor QueuedDMOperations reducer to ops pattern. · Explain WhyJul 30 2025, 4:19 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMaf21d9a43ecf: [lib] refactor QueuedDMOperations reducer to ops pattern.

Revision Contents
Changeset List

Path

Size

lib/

ops/

dm-operations-store-ops.js

2 lines

reducers/

dm-operations-queue-reducer.js

86 lines

shared/

unshim-utils.js

14 lines

Diff 49261

lib/ops/dm-operations-store-ops.js

Loading...

lib/reducers/dm-operations-queue-reducer.js

Loading...

lib/shared/unshim-utils.js

Loading...