Paths

Table of Contentst

Differential D15160

[web][native] migrate QueuedDMOperations to SQLite
ClosedPublic
Actions

Authored by kamil on Jul 29 2025, 12:35 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

tomek
bartek

Commits

rCOMMc1cb22dd8a98: [web][native] migrate QueuedDMOperations to SQLite

Summary

Depends on D15159

Test Plan

Test migration and run tests

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 29 2025, 12:35 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 29 2025, 12:35 PM

kamil added a child revision: D15161: [web][native] handle QueuedDMOperations for the backup.Jul 29 2025, 12:36 PM

Harbormaster completed remote builds in B35030: Diff 49252.Jul 29 2025, 12:53 PM

kamil published this revision for review.Jul 29 2025, 1:19 PM

kamil edited the test plan for this revision. (Show Details)

kamil added inline comments.

lib/ops/dm-operations-store-ops.js
325–334 ↗	(On Diff #49252)	It wasn't added in D15155 because this isn't really needed, only here for the test. It used on the client to added operation to DB only

tomek accepted this revision.Jul 30 2025, 2:10 PM

tomek added inline comments.

lib/ops/dm-operations-store-ops.js
536 ↗	(On Diff #49252)	We're using this type because these operations are waiting to be processed, right?

This revision is now accepted and ready to land.Jul 30 2025, 2:10 PM

kamil added inline comments.Jul 30 2025, 3:37 PM

lib/ops/dm-operations-store-ops.js
536 ↗	(On Diff #49252)	Yes, if there is an operation in `store.shimmedOperations`, it is unshimmed and ready to be processed, just waiting in the queue. If the operation is still unsupported, it shouldn't be in store but only in SQLite, see comments in D15156

Closed by commit rCOMMc1cb22dd8a98: [web][native] migrate QueuedDMOperations to SQLite. · Explain WhyJul 30 2025, 4:20 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMc1cb22dd8a98: [web][native] migrate QueuedDMOperations to SQLite.

Revision Contents
Changeset List

Path

Size

lib/

ops/

dm-operations-store-ops.js

107 lines

dm-operations-store-ops.test.js

170 lines

native/

redux/

handle-redux-migration-failure.js

1 line

persist-constants.js

2 lines

12 lines

web/

redux/

handle-redux-migration-failure.js

1 line

persist-constants.js

2 lines

12 lines

Diff 49275

lib/ops/dm-operations-store-ops.js

Loading...

lib/ops/dm-operations-store-ops.test.js

Loading...

native/redux/handle-redux-migration-failure.js

Loading...

native/redux/persist-constants.js

Loading...

native/redux/persist.js

Loading...

web/redux/handle-redux-migration-failure.js

Loading...

web/redux/persist-constants.js

Loading...

web/redux/persist.js

Loading...