[commtest] add test for Identity Farcaster API
ClosedPublic
Actions

Authored by kamil on Aug 14 2025, 3:06 PM.

Details

Reviewers

bartek
tomek

Commits

rCOMM7705b4c2645b: [commtest] add test for Identity Farcaster API

Summary

ENG-11044

Later in the stack, I am going to change it; it is easier to implement tests than to go through all cases using the app.

Depends on D15205

Test Plan

run commtest

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Aug 14 2025, 3:06 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 14 2025, 3:06 PM

kamil retitled this revision from [commtest] add test for Identity farcaster API to [commtest] add test for Identity Farcaster API.Aug 14 2025, 3:06 PM

kamil added a child revision: D15207: [comm-lib] add table for Farcaster token.Aug 14 2025, 3:14 PM

Harbormaster completed remote builds in B35286: Diff 49559.Aug 14 2025, 3:24 PM

kamil published this revision for review.Aug 14 2025, 3:39 PM

kamil mentioned this in D15208: [identity] update Farcaster tokens table when updating users table.

kamil added inline comments.

services/commtest/tests/farcaster_integration_tests.rs
202–203 ↗	(On Diff #49559)	There is something unclear here. Looking at the code, the intention was that in this case token should be removed, but it isn't. More details in https://phab.comm.dev/D15208#inline-82409