Differential D15236

[lib][web][native] add `canChangeSettings` to `ThreadProtocol` and based on that render UI
ClosedPublic
Actions

Authored by kamil on Aug 26 2025, 1:14 PM.

Details

Reviewers

tomek

Commits

rCOMM47864a1283e4: [lib][web][native] add `canChangeSettings` to `ThreadProtocol` and based on…

Summary

ENG-11168.

Test Plan

Changing color threads works for DMs and keyserver threads, is not visible for Farcaster threads. Tested on web and native

Diff Detail

Repository

rCOMM Comm

Branch

farcaster

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Aug 26 2025, 1:14 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 26 2025, 1:14 PM

Harbormaster failed remote builds in B35539: Diff 50020!Aug 26 2025, 1:15 PM

kamil added a child revision: D15243: [lib] fix cycle dependency in `farcaster-utils.js`.Aug 27 2025, 12:03 PM

kamil published this revision for review.Aug 27 2025, 12:20 PM

tomek accepted this revision.Aug 28 2025, 8:31 AM

tomek added inline comments.

lib/shared/threads/thread-spec.js
415	How about renaming it?
web/avatars/edit-thread-avatar.react.js
31

This revision is now accepted and ready to land.Aug 28 2025, 8:31 AM

rename

Harbormaster failed remote builds in B35566: Diff 50050!Aug 28 2025, 10:24 AM

This revision was landed with ongoing or failed builds.Aug 28 2025, 12:03 PM

Closed by commit rCOMM47864a1283e4: [lib][web][native] add `canChangeSettings` to `ThreadProtocol` and based on…. · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM47864a1283e4: [lib][web][native] add `canChangeSettings` to `ThreadProtocol` and based on….

Revision Contents
Changeset List

Path

Size

lib/

shared/

threads/

protocols/

dm-thread-protocol.js

6 lines

farcaster-thread-protocol.js

8 lines

keyserver-thread-protocol.js

7 lines

thread-spec.js

6 lines

native/

chat/

settings/

thread-settings.react.js

48 lines

web/

avatars/

edit-thread-avatar.react.js

9 lines

modals/

threads/

settings/

thread-settings-general-tab.react.js

60 lines

Diff 50020

View Options

lib/shared/threads/protocols/dm-thread-protocol.js

View Options

lib/shared/threads/protocols/farcaster-thread-protocol.js

View Options

lib/shared/threads/protocols/keyserver-thread-protocol.js

View Options

lib/shared/threads/thread-spec.js

View Options

native/chat/settings/thread-settings.react.js

View Options

web/avatars/edit-thread-avatar.react.js

View Options

web/modals/threads/settings/thread-settings-general-tab.react.js

[lib][web][native] add `canChangeSettings` to `ThreadProtocol` and based on that render UIClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50020

lib/shared/threads/protocols/dm-thread-protocol.js

lib/shared/threads/protocols/farcaster-thread-protocol.js

lib/shared/threads/protocols/keyserver-thread-protocol.js

lib/shared/threads/thread-spec.js

native/chat/settings/thread-settings.react.js

web/avatars/edit-thread-avatar.react.js

web/modals/threads/settings/thread-settings-general-tab.react.js

[lib][web][native] add `canChangeSettings` to `ThreadProtocol` and based on that render UI
ClosedPublic
Actions

Revision Contents
Changeset List