Depends on D15274
Details
Details
- Reviewers
kamil tomek - Commits
- rCOMMc25c235328e4: [lib] Resolve both ENS and FC names
- Tested in later diffs
- Checked that usernames are properly resolved for Comm- and Farcaster users. Also checked wallet users
- Searched for all usages of useENSNames
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Basically all changes are in ens-cache.js and stringForUserExplicit() in lib/shared/user-utils.js, and minor adjustments to satisfy Flow in these files.
Other changes are simple renames useENSNames -> useResolvableNames.
| lib/hooks/ens-cache.js | ||
|---|---|---|
| 14–23 ↗ | (On Diff #50168) | These types are based on their useFCNames and useENSNames equivalents. In fact, it's an intersection of both |
| 181–187 ↗ | (On Diff #50168) | Counterpart of useENSName() that handles both ENS and FC. Original useENSName is still needed in wallet config screens so not replacing it |
| 190–197 ↗ | (On Diff #50168) | Required for Flow to allow useResolvableNames |
| 207 ↗ | (On Diff #50168) | Flow, isViewer is false here based on above condition |
| lib/hooks/ens-cache.js | ||
|---|---|---|
| 1 ↗ | (On Diff #50168) | Should we rename this file since it's no longer just a cache for ENS names? |
Comment Actions
There is no test plan, but I witnessed it being tested yesterday in the office.
I would also add that you searched for all useENSNames to replace it, just to make sure
| lib/hooks/ens-cache.js | ||
|---|---|---|
| 1 ↗ | (On Diff #50168) | Yes, I’ll rename it to names-cache.js |