Paths

Table of Contentst

[lib] implement promoting and demoting users in Farcaster threads
ClosedPublic
Actions

Authored by kamil on Sep 4 2025, 11:48 AM.

Details

Reviewers

tomek
bartek

Commits

rCOMM39c50b8d0534: [lib] implement promoting and demoting users in Farcaster threads

Summary

ENG-11180.

Depends on D15290

Test Plan

Test changing role to admin or member. Tested on both native and web, confirmed with Farcaster prod.
Tested that only admins can modify role

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Sep 4 2025, 11:48 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 4 2025, 11:48 AM

kamil added inline comments.Sep 4 2025, 11:49 AM

lib/shared/threads/protocols/farcaster-thread-protocol.js
309–324 ↗	(On Diff #50159)	I cannot simplify this because Flow complains
334–338 ↗	(On Diff #50159)	We don't need to return updated because this is already handled by `fetchConversation`

kamil edited the test plan for this revision. (Show Details)Sep 4 2025, 11:51 AM

Harbormaster completed remote builds in B35629: Diff 50159.Sep 4 2025, 12:19 PM

kamil published this revision for review.Sep 4 2025, 12:32 PM

kamil added a child revision: D15292: [lib] avoid viewer changing its own role in Farcaster threads.Sep 4 2025, 12:46 PM

bartek accepted this revision.Sep 4 2025, 4:52 PM

This revision is now accepted and ready to land.Sep 4 2025, 4:52 PM

reabse

Harbormaster completed remote builds in B35635: Diff 50166.Sep 5 2025, 9:02 AM

Closed by commit rCOMM39c50b8d0534: [lib] implement promoting and demoting users in Farcaster threads. · Explain WhySep 5 2025, 9:12 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM39c50b8d0534: [lib] implement promoting and demoting users in Farcaster threads.

Revision Contents
Changeset List

Path

Size

lib/

hooks/

thread-hooks.js

16 lines

shared/

farcaster/

farcaster-api.js

50 lines

threads/

protocols/

farcaster-thread-protocol.js

66 lines

thread-spec.js

6 lines

Diff 50173

View Options

lib/hooks/thread-hooks.js

View Options

lib/shared/farcaster/farcaster-api.js

View Options

lib/shared/threads/protocols/farcaster-thread-protocol.js

View Options

lib/shared/threads/thread-spec.js

[lib] implement promoting and demoting users in Farcaster threadsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50173

lib/hooks/thread-hooks.js

lib/shared/farcaster/farcaster-api.js

lib/shared/threads/protocols/farcaster-thread-protocol.js

lib/shared/threads/thread-spec.js

[lib] implement promoting and demoting users in Farcaster threads
ClosedPublic
Actions

Revision Contents
Changeset List