Details
Tested entire stack end-to-end
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/shared/threads/protocols/dm-thread-protocol.js | ||
|---|---|---|
| 907–908 ↗ | (On Diff #50301) | cc. @ashoat for copy feedback, this is what is going to be shown after clicking on the icon in the top-right corner |
| lib/shared/threads/protocols/farcaster-thread-protocol.js | ||
| 773–774 ↗ | (On Diff #50301) | cc. @ashoat for copy feedback, this is what is going to be shown after clicking on the icon in the top-right corner |
| 802 ↗ | (On Diff #50301) | I make this change to test this stack without problems, as part of ENG-11208 I am going to investigate how it should be resolved properly |
| lib/shared/threads/protocols/keyserver-thread-protocol.js | ||
| 709–710 ↗ | (On Diff #50301) | cc. @ashoat for copy feedback, this is what is going to be shown after clicking on the icon in the top-right corner |
| lib/utils/alert-utils.js | ||
| 5–6 ↗ | (On Diff #50301) | cc. @ashoat for copy feedback, this is what is going to be shown after clicking the i icon when the user can't switch protocol because of what other users support, example:{F13582732} |
| lib/shared/threads/protocols/farcaster-thread-protocol.js | ||
|---|---|---|
| 768–769 ↗ | (On Diff #50301) | Might be a good idea to update these too |
Here are some edits to the copy. Let me know if any of it is too long to fit in the UI!
| lib/shared/threads/protocols/dm-thread-protocol.js | ||
|---|---|---|
| 907–908 ↗ | (On Diff #50301) | Comm DMs are end-to-end encrypted and stored locally on your device for maximum privacy. |
| lib/shared/threads/protocols/farcaster-thread-protocol.js | ||
| 774 ↗ | (On Diff #50301) | Farcaster Direct Casts are the native messaging protocol in Farcaster. They are not end-to-end encrypted, and the Farcaster team can see the contents of your messages. |
| lib/shared/threads/protocols/keyserver-thread-protocol.js | ||
| 709–710 ↗ | (On Diff #50301) | Genesis chats are a legacy chat type hosted on Ashoat's keyserver. They are not end-to-end encrypted, and Ashoat can see the contents of your messages. |
| lib/utils/alert-utils.js | ||
| 5–6 ↗ | (On Diff #50301) | This is the only chat type supported by the selected users. |