Details
Tested entire stack end-to-end
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/hooks/user-identities-hooks.js | ||
|---|---|---|
| 171 ↗ | (On Diff #50302) | renamed because of name conflict |
| lib/selectors/thread-selectors.js | ||
| 490–493 ↗ | (On Diff #50302) | For a given existing thread, we want to generate possible pending thread IDs:
|
| lib/shared/search-utils.js | ||
| 256–259 ↗ | (On Diff #50302) | I had to make this change to allow async usersSupport* calls |
| 379–384 ↗ | (On Diff #50302) | Needed to show proper icon next to username |
| 385–390 ↗ | (On Diff #50302) | Filtering users when protocol is selected |
| lib/shared/thread-utils.js | ||
| 409–410 ↗ | (On Diff #50302) | An alternative approach to this is to make pendingToRealizedThreadIDsSelector parametrized, based on the value from useProtocolSelection - I even started to implement this way, but it is more complex and requires a lot more changes |
| 1125–1126 ↗ | (On Diff #50302) | We can get rid of it now, as useProtocolSelection is doing it based on what is selected or what users are supporting |
| lib/utils/validation-utils.js | ||
| 151 ↗ | (On Diff #50302) | I updated and added tests to make sure it still works |
| native/chat/message-list-container.react.js | ||
| 269–273 ↗ | (On Diff #50302) | Unfortunately, on native, there is no better way of injecting this data into the provider without a larger refactor. On the web it is easier and we can use e,g, useInfosForPendingThread directly in provider |
| native/components/protocol-selection-provider.react.js | ||
| 50–51 ↗ | (On Diff #50302) | I should also check here if user has connected Farcaster DCs, I guess |
| web/components/protocol-selection-provider.react.js | ||
| 22 ↗ | (On Diff #50302) | There is some code duplication with ProtocolSelectionProvider, I can create a follow-up task to move this to hook |