Differential D15351

[comm-lib] Read CORS allow-origin from env
ClosedPublic
Actions

Authored by bartek on Sep 16 2025, 9:38 AM.

Details

Reviewers

tomek

Commits

rCOMM118a674896c3: [comm-lib] Read CORS allow-origin from env

Summary

ENG-10297
I had this implemented some time ago and stashed, publishing a diff.

Test Plan

I tested this on staging with my personal domain - added it to CORS via Terraform

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Sep 16 2025, 9:38 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 16 2025, 9:38 AM

Harbormaster failed remote builds in B35745: Diff 50330!Sep 16 2025, 9:43 AM

Rebase

Harbormaster failed remote builds in B35794: Diff 50407!Sep 19 2025, 9:55 AM

bartek published this revision for review.Sep 19 2025, 11:37 AM

bartek edited reviewers, added: tomek; removed: kamil.

tomek accepted this revision.Sep 19 2025, 12:05 PM

This revision is now accepted and ready to land.Sep 19 2025, 12:05 PM

This revision was landed with ongoing or failed builds.Sep 19 2025, 3:55 PM

Closed by commit rCOMM118a674896c3: [comm-lib] Read CORS allow-origin from env. · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM118a674896c3: [comm-lib] Read CORS allow-origin from env.

Revision Contents
Changeset List

Path

Size

shared/

comm-lib/

src/

http.rs

17 lines

Diff 50426

View Options

shared/comm-lib/src/http.rs

[comm-lib] Read CORS allow-origin from envClosedPublicActions