Split notif client into two layers:
- Base layer that talks directly with notif providers
- "Session" layer, that handles device token handling and is designed to send notifs received from devices via WS session
Details
Details
- Reviewers
tomek - Commits
- rCOMM007a39fa02b1: [tunnelbroker] Refactor notifs client
TB notifs still work
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
CI fails are unrelated, I'd need to rebase again
| services/tunnelbroker/src/main.rs | ||
|---|---|---|
| 68–69 ↗ | (On Diff #50382) | It is now websocket session specific, so it's created inside websocket module |
| 93–96 ↗ | (On Diff #50382) | In my local setup it awas initially failing with ambiguous message. Adding these improved the experience greatly. |
| services/tunnelbroker/src/notifs/fcm/firebase_message.rs | ||
| 41 ↗ | (On Diff #50382) | This is to fix Clippy warning about the from_str name being easy to confuse with the std FromStr trait. |
| services/tunnelbroker/src/notifs/session_client.rs | ||
| 104 ↗ | (On Diff #50382) | Refactored nested if let with this func to use early returns and flatten the code. |
| 279 ↗ | (On Diff #50382) | Another refactor to get rid of repetitive return Some(MessageSentStatus::from_result()) and improve clarity |