Paths

Table of Contentst

Differential D15379

[tunnelbroker] Use FID from tokens table for notifs
ClosedPublic
Actions

Authored by bartek on Sep 19 2025, 11:31 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMMbed0f8f6d7ff: [tunnelbroker] Use FID from tokens table for notifs

Summary

Feedback from D15373 - used FID from tokens table instead of relying on risky extraction

Depends on D15373

Test Plan

Verified that notifs still work and no notifs are received for own actions.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Sep 19 2025, 11:31 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 19 2025, 11:31 AM

bartek published this revision for review.Sep 19 2025, 11:36 AM

bartek added inline comments.

services/tunnelbroker/src/token_distributor/token_connection.rs
1 ↗	(On Diff #50412)	Almost all changes in this file are renames `self.user_id` -> `self.token_info.user_id` etc. Meaningful change is marked with my comment below
533 ↗	(On Diff #50412)	Actually, this is the meaningful change here

Harbormaster failed remote builds in B35799: Diff 50412!Sep 19 2025, 11:41 AM

tomek accepted this revision.Sep 19 2025, 12:23 PM

tomek added inline comments.

services/tunnelbroker/src/token_distributor/token_connection.rs
533 ↗	(On Diff #50412)	Can we modify `prepare_notif_payload` to accept a string instead of an optional?

This revision is now accepted and ready to land.Sep 19 2025, 12:23 PM

This revision was landed with ongoing or failed builds.Sep 19 2025, 3:55 PM

Closed by commit rCOMMbed0f8f6d7ff: [tunnelbroker] Use FID from tokens table for notifs. · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMbed0f8f6d7ff: [tunnelbroker] Use FID from tokens table for notifs.

bartek added a child revision: D15382: [tunnelbroker] Improve notif payload creation.Sep 20 2025, 8:01 AM

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

database/

token_distributor.rs

34 lines

token_distributor/

10 lines

token_connection.rs

132 lines

Diff 50425

services/tunnelbroker/src/database/token_distributor.rs

Loading...

services/tunnelbroker/src/token_distributor/mod.rs

Loading...

services/tunnelbroker/src/token_distributor/token_connection.rs

Loading...