Details
Details
- Reviewers
tomek - Commits
- rCOMM4d2016b56e01: [web] fix badge handler for web
- Test badge count when user is logged out
- Test badge count after receiving thin notif
- Test badge count after receiving thick notif
- Test badge count after receiving Farcaster notif
- Test badge count after receiving request on Farcaster
- Test badge count after receiving message to muted thread
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/push-notif/badge-handler.react.js | ||
|---|---|---|
| 103–106 | Maybe it's better to check if unreadThinThreads, unreadThickThreads, and unreadFarcasterThreads are numbers? If any of them isn't, then we will set the count to 0. | |
| web/push-notif/badge-handler.react.js | ||
|---|---|---|
| 103–106 | Overall, it shouldn't happen at all; it is implemented in a safe way now, where it checks ifthe value exists before adding it. I think I will just remove the code | |