Paths

Table of Contentst

Differential D15446

[web] fix badge handler for web
ClosedPublic
Actions

Authored by kamil on Oct 10 2025, 10:10 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMM4d2016b56e01: [web] fix badge handler for web

Summary

Fix for ENG-11401 and ENG-11403.

Did some additional refactoring to make this code easier to understand, previously everything was mixed together.

Depends on D15443

Test Plan

Test badge count when user is logged out
Test badge count after receiving thin notif
Test badge count after receiving thick notif
Test badge count after receiving Farcaster notif
Test badge count after receiving request on Farcaster
Test badge count after receiving message to muted thread

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Oct 10 2025, 10:10 AM

Herald added a subscriber: ashoat. · View Herald TranscriptOct 10 2025, 10:10 AM

Harbormaster completed remote builds in B35911: Diff 50599.Oct 10 2025, 10:29 AM

kamil requested review of this revision.Oct 10 2025, 10:29 AM

tomek accepted this revision.Oct 10 2025, 10:42 AM

tomek added inline comments.

web/push-notif/badge-handler.react.js
103–106 ↗	(On Diff #50599)	Maybe it's better to check if `unreadThinThreads`, `unreadThickThreads`, and `unreadFarcasterThreads` are numbers? If any of them isn't, then we will set the count to 0.

This revision is now accepted and ready to land.Oct 10 2025, 10:42 AM

kamil added inline comments.Oct 10 2025, 12:45 PM

web/push-notif/badge-handler.react.js
103–106 ↗	(On Diff #50599)	Overall, it shouldn't happen at all; it is implemented in a safe way now, where it checks ifthe value exists before adding it. I think I will just remove the code

remove type check

Harbormaster completed remote builds in B35913: Diff 50602.Oct 10 2025, 1:55 PM

Closed by commit rCOMM4d2016b56e01: [web] fix badge handler for web. · Explain WhyOct 10 2025, 1:56 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM4d2016b56e01: [web] fix badge handler for web.

Revision Contents
Changeset List

Path

Size

web/

push-notif/

badge-handler.react.js

98 lines

Diff 50605

web/push-notif/badge-handler.react.js

Loading...