[lib] Improve message fetch stop condition
ClosedPublic
Actions

Authored by tomek on Oct 14 2025, 10:50 AM.

Details

Reviewers

Commits

rCOMM2dd6c5e6547c: [lib] Improve message fetch stop condition

Summary

Instead of breaking when we receive a batch ending with the same message, check if a batch doesn't contain any new message. Also, if a batch doesn't contain any messages, break the processing.

https://linear.app/comm/issue/ENG-11427/user-unable-to-sync-dcs

Test Plan

Check if the sync works.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Oct 14 2025, 10:50 AM

Herald added a subscriber: ashoat. · View Herald TranscriptOct 14 2025, 10:50 AM

Harbormaster completed remote builds in B35926: Diff 50624.Oct 14 2025, 11:08 AM

tomek requested review of this revision.Oct 14 2025, 11:08 AM

kamil accepted this revision.Oct 14 2025, 12:19 PM

This revision is now accepted and ready to land.Oct 14 2025, 12:19 PM

Closed by commit rCOMM2dd6c5e6547c: [lib] Improve message fetch stop condition. · Explain WhyOct 14 2025, 12:54 PM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM2dd6c5e6547c: [lib] Improve message fetch stop condition.

tomek added inline comments.Oct 15 2025, 4:30 PM

lib/shared/farcaster/farcaster-hooks.js
772–774 ↗	(On Diff #50634)	This is completely broken

tomek added inline comments.Oct 15 2025, 4:37 PM

lib/shared/farcaster/farcaster-hooks.js
772–774 ↗	(On Diff #50634)	Fixed in D15480

Revision Contents
Changeset List

Path

Size

lib/

shared/

farcaster/

farcaster-hooks.js

15 lines

Diff 50624

View Options

lib/shared/farcaster/farcaster-hooks.js

[lib] Improve message fetch stop conditionClosedPublicActions