talked IRL with ashoat about removing timestamp
follow up diff here: https://phabricator.ashoat.com/D3163
Details
Details
- Reviewers
atul ashoat - Commits
- rCOMMa27f687018e6: [web] [remove] lastActivity from thread
make sure page renders
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I think that if we do this, we should also adjust the timestamp we show for the top-level "channel" to include the latest timestamp from any thread. That way the timestamps will actually appear to be chronological. We might want to reposition them to make this clear, eg. avoid lining up the timestamp with the text, since that implies the two are connected
Comment Actions
Accepting because this looks right, but personally don't think we should remove timestamps for sidebars
| web/chat/sidebar-item.react.js | ||
|---|---|---|
| 21 ↗ | (On Diff #9538) | extraneous newline |
Comment Actions
Where are we tracking the task of updating the timestamp for the top-level entity to include the most recent timestamp of a contained sidebar? (The goal being to make sure the timestamps appear chronologically)
Comment Actions
Where are we tracking the task of updating the timestamp for the top-level entity to include the most recent timestamp of a contained sidebar? (The goal being to make sure the timestamps appear chronologically)
Just saw a diff for that.
personally don't think we should remove timestamps for sidebars
I'm not sure about it myself. What do you think about the fact that the timestamps aren't chronological today? And doesn't it feel a bit cluttered with all of the timestamps? What do you think the value of the timestamp is?