[web] [feat] thread menu button hoverable
ClosedPublic
Actions

Authored by • benschac on Feb 3 2022, 12:51 PM.

Details

Reviewers

atul
ashoat

Commits

rCOMMe6ae1375ea6c: [web] [feat] thread menu button hoverable

Summary

remove menu button for threads

updated with hover:

note: arrow positioning updated in future diffs.

Test Plan

should render, look like screen shot

Repository

rCOMM Comm

Branch

actuallylandme

Lint

No Lint Coverage

Unit

No Test Coverage

• benschac requested review of this revision.Feb 3 2022, 12:56 PM

Wait, does this make it impossible to mark a thread as unread? We definitely shouldn't lose that. Maybe we can make it appear on hover?

This revision now requires changes to proceed.Feb 3 2022, 8:05 PM

That's fair. Let's make it appear on hover.

make menu hoverable

• benschac retitled this revision from [web] [remove] thread menu button to [web] [feat] thread menu button hoverable.Feb 8 2022, 7:44 AM

• benschac edited the summary of this revision. (Show Details)

atul accepted this revision.Feb 8 2022, 8:47 AM

atul added inline comments.

web/chat/chat-thread-list.css
125–130 ↗	(On Diff #9398)	Probably overkill and don't recommend making this change... but since `div`s are `display: block` by default, I think we could do something like this: div.sidebar:not(:hover) .menu { display: none; }