Page MenuHomePhabricator

[CommCoreModule] Pass `setReadyState` callback to `ClientGetReadReactor`
ClosedPublic

Authored by atul on Feb 3 2022, 3:32 PM.
Tags
None
Referenced Files
F3521868: D3101.diff
Mon, Dec 23, 5:16 AM
Unknown Object (File)
Nov 16 2024, 2:23 AM
Unknown Object (File)
Nov 13 2024, 5:09 AM
Unknown Object (File)
Nov 13 2024, 5:09 AM
Unknown Object (File)
Nov 13 2024, 5:08 AM
Unknown Object (File)
Nov 13 2024, 5:08 AM
Unknown Object (File)
Nov 13 2024, 5:08 AM
Unknown Object (File)
Nov 5 2024, 12:51 AM

Details

Summary

Rethought this a bit.. I previously thought multiple objects on the "network" thread would need to "hold on" to this function, but I think we can just pass it to ClientGetReadReactor which should be able to handle setting the readyState for all stages of the grpc stream request lifecycle.

Test Plan

Will be tested implicitly with subsequent diffs.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

remove extraneous member variable

atul requested review of this revision.Feb 3 2022, 3:42 PM
This revision is now accepted and ready to land.Feb 3 2022, 8:15 PM