[services] Tunnelbroker - Database entities for messages.
ClosedPublic
Actions

Authored by • max on Feb 4 2022, 7:27 PM.

Details

Reviewers

tomek
• karol
ashoat
• jim

Commits

rCOMM8ff835508155: [services] Tunnelbroker - Database entities for messages.

Summary

DynamoDB database entities for persisting messages that pass in tunnelbroker.

Related linear task: ENG-670

Dependencies:

Depends on D3116 to provide ConfigManager.

Test Plan

Using entities for CRUD operations.

Diff Detail

Repository

rCOMM Comm

Branch

@max/@karol/tunnelbroker-newstack

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Feb 4 2022, 7:27 PM

Herald added subscribers: • karol, atul, • adrian and 2 others. · View Herald TranscriptFeb 4 2022, 7:27 PM

• max retitled this revision from [services] Tunnelbroker - Messages database entities. to [services] Tunnelbroker - Database entities for messages..Feb 4 2022, 7:29 PM

• max edited the summary of this revision. (Show Details)

• max added reviewers: tomek, • karol.

Harbormaster completed remote builds in B6567: Diff 9312.Feb 4 2022, 7:32 PM

• max requested review of this revision.Feb 4 2022, 7:32 PM

Expire field were added.

• max edited the summary of this revision. (Show Details)Feb 6 2022, 5:37 PM

• max added a parent revision: D3116: [services] Tunnelbroker - Add messages table name to ConfigManager..

Harbormaster completed remote builds in B6578: Diff 9325.Feb 6 2022, 5:39 PM

• max added a child revision: D3117: [services] Tunnelbroker - Database public functions for messages..Feb 6 2022, 5:43 PM

tomek accepted this revision.Feb 7 2022, 2:20 AM

tomek added inline comments.

services/tunnelbroker/docker-server/contents/server/src/Database/DatabaseEntitiesTools.h
27 ↗	(On Diff #9325)	Can we use the new approach here - to avoid listing all the types?

This revision is now accepted and ready to land.Feb 7 2022, 2:20 AM

Herald added a reviewer: ashoat. · View Herald TranscriptFeb 7 2022, 2:20 AM

Herald added a subscriber: • benschac. · View Herald Transcript

This revision now requires review to proceed.Feb 7 2022, 2:20 AM

• karol accepted this revision.Feb 7 2022, 4:49 AM

ashoat accepted this revision.Feb 7 2022, 6:59 PM

ashoat added a reviewer: • jim.

ashoat added inline comments.

services/tunnelbroker/docker-server/contents/server/src/Database/DatabaseEntitiesTools.h
27 ↗	(On Diff #9325)	We are currently tracking this in ENG-324 after ENG-567 was closed. It is currently assigned to @karol-bisztyga, but I'm sure he wouldn't mind if @geekbrother handles it. We should just make sure there's no duplication of work

This revision is now accepted and ready to land.Feb 7 2022, 6:59 PM

LGTM

Rebase.

Harbormaster failed remote builds in B6662: Diff 9429!Feb 8 2022, 7:08 PM

• max added inline comments.Feb 8 2022, 7:12 PM

services/tunnelbroker/docker-server/contents/server/src/Database/DatabaseEntitiesTools.h
27 ↗	(On Diff #9325)	Can we use the new approach here - to avoid listing all the types? Yep, it's tracked here now.
27 ↗	(On Diff #9325)	We are currently tracking this in ENG-324 after ENG-567 was closed. It is currently assigned to @karol-bisztyga, but I'm sure he wouldn't mind if @geekbrother handles it. We should just make sure there's no duplication of work Yes right, but I've created a separate task [[ https://linear.app/comm/issue/ENG-706/avoid-listing-all-entities-in-databaseentitiestoolsh-in-tunnelbroker \| ENG-706 ]]for the tunnelbroker.