Paths

Table of Contentst

[CommCoreModule] Make `GRPCStreamHostObj.readyState` readonly
ClosedPublic
Actions

Authored by atul on Feb 7 2022, 12:22 PM.

Tags

None

Referenced Files

	F2899411: D3128.diff
	Sat, Oct 5, 7:06 AM

	Unknown Object (File)
	Tue, Sep 24, 8:50 PM

	Unknown Object (File)
	Thu, Sep 19, 11:10 PM

	Unknown Object (File)
	Thu, Sep 19, 12:06 PM

	Unknown Object (File)
	Thu, Sep 19, 7:27 AM

	Unknown Object (File)
	Thu, Sep 19, 6:02 AM

	Unknown Object (File)
	Sat, Sep 14, 7:21 AM

	Unknown Object (File)
	Sat, Sep 14, 7:21 AM

View All Files

Subscribers

• adrian

• benschac

Details

Reviewers

ashoat
varun
• karol
tomek
• jacek
• jim

Commits

rCOMM10a6a24973e7: [CommCoreModule] Make `GRPCStreamHostObj.readyState` readonly

Summary

Shouldn't be able to set readyState from the JS side

Test Plan

NA, still builds as expected

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Feb 7 2022, 12:22 PM

Herald added subscribers: • benschac, • adrian. · View Herald TranscriptFeb 7 2022, 12:22 PM

Harbormaster completed remote builds in B6601: Diff 9357.Feb 7 2022, 12:27 PM

atul requested review of this revision.Feb 7 2022, 12:27 PM

Oh yeah lol

This revision is now accepted and ready to land.Feb 7 2022, 7:32 PM

rebase before landing

Harbormaster completed remote builds in B6623: Diff 9387.Feb 8 2022, 5:36 AM

Closed by commit rCOMM10a6a24973e7: [CommCoreModule] Make `GRPCStreamHostObj.readyState` readonly (authored by atul). · Explain WhyFeb 8 2022, 5:38 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM10a6a24973e7: [CommCoreModule] Make `GRPCStreamHostObj.readyState` readonly.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

grpc/

GRPCStreamHostObject.cpp

5 lines

Diff 9388

View Options

native/cpp/CommonCpp/grpc/GRPCStreamHostObject.cpp

[CommCoreModule] Make `GRPCStreamHostObj.readyState` readonlyClosedPublicActions