[native] Add sendPong method
ClosedPublic
Actions

Authored by tomek on Feb 8 2022, 6:56 AM.

Details

Reviewers

• karol
ashoat
atul
• jim

Commits

rCOMMc304dcad62dc: [native] Add sendPong method

Summary

Add a C++ method that can be called from java. This method should be called in a response to PING background notification.
We're still using an old method here, which will be replaced by send soon, but updating it should be trivial.

Depends on D3132

Test Plan

Modify notification handling code to call NetworkModule.sendPong(), send a notification and check if the C++ code was called

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Feb 8 2022, 6:56 AM

Herald added subscribers: atul, • adrian, ashoat. · View Herald TranscriptFeb 8 2022, 6:56 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 8 2022, 7:07 AM

Harbormaster failed remote builds in B6630: Diff 9395!

Update

Harbormaster completed remote builds in B6671: Diff 9442.Feb 9 2022, 5:04 AM

tomek requested review of this revision.Feb 9 2022, 5:04 AM

looks ok I think

This revision is now accepted and ready to land.Feb 9 2022, 5:11 AM

Herald added a reviewer: ashoat. · View Herald TranscriptFeb 9 2022, 5:11 AM

Herald added a subscriber: • benschac. · View Herald Transcript

This revision now requires review to proceed.Feb 9 2022, 5:11 AM

Same comment as D3132:

I really don't know much about what's going on here... @karol-bisztyga and @palys-swm are the only ones on the team who have really explored Android JNI generally or fbjni specifically. Adding @jimpo since I know he's done some Android stuff, but not sure if he has context. Will accept, deferring to @karol-bisztyga and @palys-swm.