Page MenuHomePhabricator
Differential D3139

[web] [fix] breadcrumb / ancestor wrap breaking layout
ClosedPublic
Actions

Authored by • benschac on Feb 8 2022, 11:09 AM.
Tags
None
Referenced Files
F3312382: D3139.diff
Tue, Nov 19, 10:22 AM
Unknown Object (File)
Sat, Nov 2, 4:05 AM
Unknown Object (File)
Sat, Nov 2, 4:04 AM
Unknown Object (File)
Sat, Nov 2, 4:04 AM
Unknown Object (File)
Sat, Nov 2, 4:01 AM
Unknown Object (File)
Oct 18 2024, 5:35 PM
Unknown Object (File)
Oct 18 2024, 5:35 PM
Unknown Object (File)
Oct 7 2024, 6:52 AM
View All 76 Files
Subscribers
• adrian
ashoat
• jacek
• karol
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMM710d2473ef7b: [web] [fix] breadcrumb / ancestor wrap breaking layout
Summary

before:

Image 2022-02-08 at 2.10.12 PM.jpg (432×1 px, 50 KB)

after:
Image 2022-02-08 at 2.07.07 PM.jpg (1×862 px, 128 KB)

Test Plan

make sure it looks like the screen shot

Diff Detail

Repository
rCOMM Comm
Branch
current-work
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• benschac created this revision.Feb 8 2022, 11:09 AM
Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptFeb 8 2022, 11:09 AM
• benschac edited the summary of this revision. (Show Details)Feb 8 2022, 11:10 AM
Harbormaster completed remote builds in B6642: Diff 9406.Feb 8 2022, 11:19 AM
• benschac requested review of this revision.Feb 8 2022, 11:19 AM
atul accepted this revision.Feb 8 2022, 11:55 AM

What does it look like when the width of the ancestor path extends beyond the thread list?

This revision is now accepted and ready to land.Feb 8 2022, 11:55 AM
Herald added a reviewer: ashoat. · View Herald TranscriptFeb 8 2022, 11:55 AM
This revision now requires review to proceed.Feb 8 2022, 11:55 AM
ashoat accepted this revision.Feb 8 2022, 9:36 PM
This revision is now accepted and ready to land.Feb 8 2022, 9:36 PM
• benschac added a subscriber: • jacek.Feb 9 2022, 6:00 AM
In D3139#82941, @atul wrote:

What does it look like when the width of the ancestor path extends beyond the thread list?

I'm not sure. Just saw @def-au1t has a middle component if ancestor threads get too long per the design. I can add it here have his diff lands.

Closed by commit rCOMM710d2473ef7b: [web] [fix] breadcrumb / ancestor wrap breaking layout (authored by • benschac). · Explain WhyFeb 9 2022, 6:59 AM
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMM710d2473ef7b: [web] [fix] breadcrumb / ancestor wrap breaking layout.

Revision Contents
Changeset List

PathSize
web/
chat/
2 lines

Diff 9406

View Options

web/chat/chat-thread-list.css

Loading...