[web] [fix] Calendar is on two lines
ClosedPublic
Actions

Authored by • benschac on Feb 8 2022, 11:36 AM.

Details

Reviewers

atul
ashoat

Commits

rCOMM48d8013dc7f6: [web] [fix] Calendar is on two lines

Summary

make calendar on one line
before:

Image 2022-02-08 at 2.37.22 PM.jpg (652×1 px, 55 KB)

after:

Test Plan

should look like screen shot

Diff Detail

Repository

rCOMM Comm

Branch

current-work

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Feb 8 2022, 11:36 AM

Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptFeb 8 2022, 11:36 AM

• benschac edited the summary of this revision. (Show Details)Feb 8 2022, 11:37 AM

Harbormaster completed remote builds in B6646: Diff 9411.Feb 8 2022, 11:41 AM

• benschac requested review of this revision.Feb 8 2022, 11:41 AM

Since we're using absolute units here, have you made sure the issue doesn't persist at other breakpoints/(reasonable) zoom levels?

This revision is now accepted and ready to land.Feb 8 2022, 12:00 PM

Herald added a reviewer: ashoat. · View Herald TranscriptFeb 8 2022, 12:00 PM

This revision now requires review to proceed.Feb 8 2022, 12:00 PM

Does this work for all the months? (Longest and shortest)
Does this keep the < and > buttons in the same place when you click them?

This revision is now accepted and ready to land.Feb 8 2022, 9:37 PM

In D3141#83178, @ashoat wrote:

Does this work for all the months? (Longest and shortest)

Does this keep the < and > buttons in the same place when you click them?

Screen Recording 2022-02-09 at 10.32.40 AM.gif (300×1 px, 788 KB)

(gif)
yes

In D3141#82950, @atul wrote:

Since we're using absolute units here, have you made sure the issue doesn't persist at other breakpoints/(reasonable) zoom levels?

yes, it breaks with the rest of the layout in the same places it did before. I was never fully responsive.

Closed by commit rCOMM48d8013dc7f6: [web] [fix] Calendar is on two lines (authored by • benschac). · Explain WhyFeb 9 2022, 7:36 AM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMM48d8013dc7f6: [web] [fix] Calendar is on two lines.