Page MenuHomePhabricator
Differential D3142

[web] [fix] add the right icon the chat tabs
ClosedPublic
Actions

Authored by • benschac on Feb 8 2022, 11:43 AM.
Tags
None
Referenced Files
F3313791: D3142.diff
Tue, Nov 19, 12:20 PM
Unknown Object (File)
Sat, Nov 2, 4:05 AM
Unknown Object (File)
Sat, Nov 2, 4:05 AM
Unknown Object (File)
Sat, Nov 2, 4:04 AM
Unknown Object (File)
Sat, Nov 2, 4:00 AM
Unknown Object (File)
Fri, Oct 25, 12:00 AM
Unknown Object (File)
Fri, Oct 25, 12:00 AM
Unknown Object (File)
Oct 7 2024, 6:51 AM
View All 77 Files
Subscribers
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMMe586fd3cb7e9: [web] [fix] add the right icon the chat tabs
Summary

per figma this is the right icon. When uploading to icomoon I forgot to re-name it. Not sure it's a big deal. Letting y'all decide.

before:

Image 2022-02-08 at 2.44.01 PM.jpg (328×896 px, 36 KB)

after:
Image 2022-02-08 at 2.41.17 PM.jpg (214×888 px, 24 KB)

https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A79456

Test Plan

should look like figma

Diff Detail

Repository
rCOMM Comm
Branch
current-work
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• benschac created this revision.Feb 8 2022, 11:43 AM
Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptFeb 8 2022, 11:43 AM
• benschac edited the summary of this revision. (Show Details)Feb 8 2022, 11:44 AM
• benschac edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B6647: Diff 9412.Feb 8 2022, 11:48 AM
• benschac requested review of this revision.Feb 8 2022, 11:48 AM
atul added a comment.Feb 8 2022, 12:05 PM

I prefer the new icon... the iconset is inconsistent with straight/rounded edges, but I think this fits better.

Not sure if it should be addressed in a later diff in this stack or deferred for later, but we might want to go with a more descriptive name than Filled for this icon? Something like message-rounded-filled?

atul accepted this revision.Feb 8 2022, 12:05 PM
This revision is now accepted and ready to land.Feb 8 2022, 12:05 PM
Herald added a reviewer: ashoat. · View Herald TranscriptFeb 8 2022, 12:05 PM
This revision now requires review to proceed.Feb 8 2022, 12:05 PM
ashoat accepted this revision.Feb 8 2022, 9:37 PM
This revision is now accepted and ready to land.Feb 8 2022, 9:37 PM
Closed by commit rCOMMe586fd3cb7e9: [web] [fix] add the right icon the chat tabs (authored by • benschac). · Explain WhyFeb 9 2022, 6:57 AM
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMMe586fd3cb7e9: [web] [fix] add the right icon the chat tabs.

Revision Contents
Changeset List

PathSize
web/
chat/
2 lines

Diff 9412

View Options

web/chat/chat-tabs.react.js

Loading...