[lib] Simplify filterChatThreadList
ClosedPublic
Actions

Authored by ashoat on Feb 9 2022, 3:42 AM.

Details

Reviewers

• jacek
tomek

Commits

rCOMM03db030f6828: [lib] Simplify filterChatThreadList

Summary

It's good this function got factored out, because it turns out the logic can be significantly simplified now.

Depends on D2885

Test Plan

Flow, careful code inspection

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 9 2022, 3:42 AM

Herald added subscribers: • karol, atul, • adrian. · View Herald TranscriptFeb 9 2022, 3:42 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 9 2022, 3:44 AM

Harbormaster failed remote builds in B6663: Diff 9431!

Build failure is unrelated (backup service)

tomek accepted this revision.Feb 9 2022, 11:34 AM

This revision is now accepted and ready to land.Feb 9 2022, 11:34 AM

Herald added a subscriber: • benschac. · View Herald TranscriptFeb 9 2022, 11:34 AM

• jacek accepted this revision.Feb 11 2022, 10:39 AM

Rebase

Harbormaster completed remote builds in B6847: Diff 9690.Feb 15 2022, 7:03 PM

Closed by commit rCOMM03db030f6828: [lib] Simplify filterChatThreadList. · Explain WhyFeb 16 2022, 3:54 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM03db030f6828: [lib] Simplify filterChatThreadList.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

54 lines

Diff 9706

View Options

lib/shared/thread-utils.js

[lib] Simplify filterChatThreadListClosedPublicActions