Introduced thread top bar component with thread name, ancestors (in the following diff) and settings menu on the right.
Details
Details
- Reviewers
tomek • benschac atul ashoat - Commits
- rCOMMa535412aecb7: [web] Introduce thread top bar
Compared result with design in figma and confirmed, that it is displayed correctly for all threads.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/chat/chat-thread-top-bar.react.js | ||
|---|---|---|
| 14 | https://phabricator.ashoat.com/D3148 seems very similar to this logic/color implementation. Could be worth making it a hook? | |
| 16 | nit: been using background for the most part. I _feel_ like it's a bit easier to notice. background v. color. | |
Comment Actions
Renamed file, replaced backgroundColor with background, added newline after flow annotation
| web/chat/thread-top-bar.react.js | ||
|---|---|---|
| 29 ↗ | (On Diff #9477) | nit: can this be a p. Sorry I missed this last time |
| web/chat/thread-top-bar.react.js | ||
|---|---|---|
| 29 ↗ | (On Diff #9477) | @benschac please do not leave comments requesting changes without actually hitting the "Request Changes" button. I know you probably feel that requesting changes is intense, but by leaving a comment like this you aren't putting this diff in the author's queue. Please be thoughtful about diff queues going forward |
| web/chat/thread-top-bar.react.js | ||
|---|---|---|
| 29 ↗ | (On Diff #9477) | Hmm actually in this case it's already in @def-au1t's queue to land. Maybe this isn't as big of a deal as I originally thought |