Page MenuHomePhabricator
Differential D3333

[web] Show sidebars modal from thread menu
ClosedPublic
Actions

Authored by • jacek on Mar 4 2022, 5:38 AM.
Tags
None
Referenced Files
F3298883: D3333.diff
Sun, Nov 17, 9:38 AM
Unknown Object (File)
Wed, Nov 13, 12:35 PM
Unknown Object (File)
Tue, Oct 22, 11:15 AM
Unknown Object (File)
Tue, Oct 22, 11:15 AM
Unknown Object (File)
Tue, Oct 22, 11:15 AM
Unknown Object (File)
Tue, Oct 22, 2:03 AM
Unknown Object (File)
Tue, Oct 22, 12:26 AM
Unknown Object (File)
Sep 24 2024, 2:01 AM
View All Files
Subscribers
• adrian
ashoat
atul
• karol

Details

Reviewers
tomek
• benschac
atul
ashoat
Commits
rCOMM871eb88878fe: [web] Show sidebars modal from thread menu
Summary

Add action on Sidebars item in thread menu. It displays modal with sidebars.

Test Plan

Select thread with sidebars inside and select "Sidebars" from thread menu

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jacek created this revision.Mar 4 2022, 5:38 AM
Herald added subscribers: • karol, atul, • adrian, ashoat. · View Herald TranscriptMar 4 2022, 5:38 AM
Harbormaster completed remote builds in B7144: Diff 10069.Mar 4 2022, 5:43 AM
• jacek requested review of this revision.Mar 4 2022, 5:43 AM
• jacek added reviewers: • benschac, atul.Mar 4 2022, 8:13 AM
tomek accepted this revision.Mar 4 2022, 10:29 AM
This revision is now accepted and ready to land.Mar 4 2022, 10:29 AM
ashoat requested changes to this revision.Mar 7 2022, 10:06 PM
ashoat added inline comments.
web/chat/thread-menu.react.js
84 ↗(On Diff #10069)

Here I think it would be good practice to separate out this onClick into its own React.useCallback. It's the exact scenario I described in D3332 – a change to hasSidebars here will cause onClick to be regenerated, when otherwise it wouldn't have to be.

This revision now requires changes to proceed.Mar 7 2022, 10:06 PM
• jacek updated this revision to Diff 10135.Mar 8 2022, 2:36 AM

Move callback into React.useCallback

Harbormaster completed remote builds in B7206: Diff 10135.Mar 8 2022, 2:44 AM
ashoat accepted this revision.Mar 8 2022, 9:15 AM
This revision is now accepted and ready to land.Mar 8 2022, 9:15 AM
Closed by commit rCOMM871eb88878fe: [web] Show sidebars modal from thread menu (authored by • jacek). · Explain WhyMar 9 2022, 7:20 AM
This revision was automatically updated to reflect the committed changes.
• jacek added a commit: rCOMM871eb88878fe: [web] Show sidebars modal from thread menu.

Revision Contents
Changeset List

PathSize
web/
chat/
18 lines

Diff 10135

View Options

web/chat/thread-menu.react.js

Loading...