Paths

Table of Contentst

Differential D3352

[native] Make MessageList able to fetch messages if none are present
ClosedPublic
Actions

Authored by ashoat on Mar 7 2022, 12:18 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

tomek
atul

Commits

rCOMMb24bedc0e4bf: [native] Make MessageList able to fetch messages if none are present

Summary

With the changes in the earlier diff, we may end up with zero messages for a given thread. This diff makes it possible for us to fetch messages in that case.

Depends On D3351

Test Plan

I decreased defaultMaxMessageAge such that no messages got loaded at all, and made sure that when I opened a thread without messages, the messages were fetche
d

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 7 2022, 12:18 AM

Herald added subscribers: • karol, • adrian. · View Herald TranscriptMar 7 2022, 12:18 AM

ashoat added a child revision: D3353: [lib] Show loader when there are no messages.Mar 7 2022, 12:20 AM

Harbormaster completed remote builds in B7172: Diff 10098.Mar 7 2022, 12:23 AM

ashoat requested review of this revision.Mar 7 2022, 12:23 AM

ashoat mentioned this in D3354: [server] Gate global time filter for message queries on codeVersion.Mar 7 2022, 6:16 AM

ashoat mentioned this in D3349: [server] Always filter message queries by message creation time.Mar 7 2022, 6:16 AM

tomek accepted this revision.Mar 8 2022, 2:50 PM

This revision is now accepted and ready to land.Mar 8 2022, 2:50 PM

Herald added a subscriber: • benschac. · View Herald TranscriptMar 8 2022, 2:50 PM

Rebase

Harbormaster completed remote builds in B7218: Diff 10148.Mar 8 2022, 4:10 PM

Closed by commit rCOMMb24bedc0e4bf: [native] Make MessageList able to fetch messages if none are present. · Explain WhyMar 8 2022, 4:33 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMb24bedc0e4bf: [native] Make MessageList able to fetch messages if none are present.

ashoat mentioned this in rCOMM00e559c14bef: [server] Gate global time filter for message queries on codeVersion.

ashoat mentioned this in D3411: [server] Don't unset TRUNCATED if threadCursor is null.Mar 11 2022, 7:39 PM

ashoat mentioned this in rCOMM362a843ed259: [server] Don't unset TRUNCATED if threadCursor is null.Mar 14 2022, 7:47 PM

Revision Contents
Changeset List

Path

Size

native/

chat/

message-list.react.js

9 lines

Diff 10156

native/chat/message-list.react.js

Loading...