Page MenuHomePhabricator

[web] [fix] fix console error
ClosedPublic

Authored by benschac on Mar 7 2022, 12:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 5:18 AM
Unknown Object (File)
Mon, Apr 29, 4:33 PM
Unknown Object (File)
Fri, Apr 19, 2:44 PM
Unknown Object (File)
Fri, Apr 19, 2:44 PM
Unknown Object (File)
Fri, Apr 19, 2:44 PM
Unknown Object (File)
Fri, Apr 19, 2:44 PM
Unknown Object (File)
Fri, Apr 19, 2:27 PM
Unknown Object (File)
Mar 27 2024, 12:35 AM
Tokens
"Burninate" token, awarded by atul.

Details

Summary

fix error in console
https://linear.app/comm/issue/ENG-839/react-dom-warning-in-console

react_devtools_backend.js:4061 Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p>.
    in div (created by AppSwitcher)
    in span (created by AppSwitcher)
    in p (created by AppSwitcher)
    in li (created by AppSwitcher)
    in ul (created by AppSwitcher)
    in div (created by AppSwitcher)
    in AppSwitcher (created by LeftLayoutAside)
    in aside (created by LeftLayoutAside)
    in LeftLayoutAside (created by App)
    in div (created by App)
    in DndProvider (created by App)
    in App (created by ConnectedApp)
    in ConnectedApp (created by AppWithProvider)
    in ModalProvider (created by AppWithProvider)
    in AppWithProvider (created by Context.Consumer)
    in Route (created by RootComponent)
    in Router (created by RootComponent)
    in RootComponent (created by HotExportedRootComponent)
    in AppContainer (created by HotExportedRootComponent)
    in HotExportedRootComponent (created by RootProvider)
    in Provider (created by RootProvider)
    in RootProvider
Test Plan

Error should no longer load, you need to have unread messages in order to trigger the error.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

benschac edited the test plan for this revision. (Show Details)
benschac edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Mar 7 2022, 1:13 PM

Seems right, can you check to make sure things continue to look as expected before landing? Assuming you have, but just to double check

Image 2022-03-09 at 11.34.05 AM.jpg (1×2 px, 236 KB)

before and after look the same to me.

This revision was landed with ongoing or failed builds.Mar 9 2022, 8:52 AM
This revision was automatically updated to reflect the committed changes.

Sorry everyone, I should have waited for the build to finish after rebasing. This won't happen again.