Page MenuHomePhabricator

[landing] Add "launch app" icon to `Header`
ClosedPublic

Authored by atul on Mar 9 2022, 1:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 3, 3:48 PM
Unknown Object (File)
Fri, Dec 27, 9:34 AM
Unknown Object (File)
Fri, Dec 27, 9:34 AM
Unknown Object (File)
Fri, Dec 27, 9:34 AM
Unknown Object (File)
Fri, Dec 27, 9:34 AM
Unknown Object (File)
Wed, Dec 25, 3:03 AM
Unknown Object (File)
Wed, Dec 25, 3:02 AM
Unknown Object (File)
Wed, Dec 25, 3:02 AM

Details

Summary

Adding an icon so the web app (https://web.comm.app) can be launched from the landing page.

Note: Won't land this diff until https://web.comm.app is live

Test Plan

Here's what the header looks like after:

Screen Shot 2022-03-09 at 7.36.27 PM.png (9 MB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul requested review of this revision.Mar 9 2022, 1:34 PM
tomek added a reviewer: ashoat.
tomek added inline comments.
landing/header.react.js
49–51 ↗(On Diff #10255)

Not really sure if it will be intuitive for users that this icon opens our web app

benschac added inline comments.
landing/header.react.js
49–51 ↗(On Diff #10255)

Agreed. I think something like "open app" or even just app would be easier. Or possibly just signin/signup?

Image 2022-03-10 at 10.38.25 AM.jpg (2×2 px, 629 KB)
-- get started

Image 2022-03-10 at 10.39.27 AM.jpg (2×2 px, 559 KB)
-- login

Image 2022-03-10 at 10.40.03 AM.jpg (2×2 px, 401 KB)
-- install / login

This revision now requires changes to proceed.Mar 10 2022, 7:41 AM
atul requested review of this revision.Mar 10 2022, 11:51 AM

I spoke w/ @ashoat, and I think for now we kind of want to keep it subtle/don't want to advertise it too much

ashoat requested changes to this revision.Mar 10 2022, 8:09 PM

The icons feel a bit too far apart, can they be moved closer?

And yeah I want to keep this understated... we're not trying to advertise the fact that this is live.

This revision now requires changes to proceed.Mar 10 2022, 8:09 PM

The icons feel a bit too far apart, can they be moved closer?

Yeah, they're space-between here so it looks too far apart on desktop and too close together on mobile. Should be addressed in https://phabricator.ashoat.com/D3404 where we switch to flex-end and have constant space between the icons.

atul requested review of this revision.Mar 11 2022, 6:33 AM
This revision is now accepted and ready to land.Mar 11 2022, 7:24 AM

Heads up @ashoat @benschac @palys-swm (reviewers), I added an isDev check to conditionally render the "launch app" icon so I can land this diff (and later diffs in the stack) as-is. I don't think this should require re-review...but figured I'd flag it

This revision was landed with ongoing or failed builds.Mar 15 2022, 2:58 PM
This revision was automatically updated to reflect the committed changes.

Agree there's no need for re-review