[web] [chore] add remaining icons to the project icon component
ClosedPublic
Actions

Authored by • benschac on Mar 9 2022, 2:35 PM.

Details

Reviewers

atul

Commits

rCOMM71290bcc073c: [web] [chore] add remaining icons to the project icon component

Summary

Add additional icons to the project. I looked through all of the web figma files and these we're the remaining icons that had not been imported.

Image 2022-03-09 at 5.35.34 PM.jpg (1×3 px, 355 KB)

(white icon is the reply bubble which I had to manually export out of Figma because it wasn't in the SWM icon pack)

Test Plan

Icon component should still work as expected. It will support additional icons that have not been imported (icomoon json svg json comming in the next diff)

Diff Detail

Repository

rCOMM Comm

Branch

update-icons-last-time

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Mar 9 2022, 2:35 PM

Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 9 2022, 2:35 PM

• benschac edited the summary of this revision. (Show Details)Mar 9 2022, 2:36 PM

Harbormaster completed remote builds in B7271: Diff 10253.Mar 9 2022, 2:40 PM

• benschac requested review of this revision.Mar 9 2022, 2:40 PM

btw can we use the icons that already exist in lib/shared/swmansion-icon-config.json?

atul accepted this revision.Mar 9 2022, 9:07 PM

This revision is now accepted and ready to land.Mar 9 2022, 9:07 PM

In D3391#91577, @atul wrote:

btw can we use the icons that already exist in lib/shared/swmansion-icon-config.json?

Not sure, I'd imagine we'd need to rename the icons we have already set here though, some of these icons didn't have names. Additionally, I removed the prefix outline or duotone.

Closed by commit rCOMM71290bcc073c: [web] [chore] add remaining icons to the project icon component (authored by • benschac). · Explain WhyMar 10 2022, 4:16 AM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMM71290bcc073c: [web] [chore] add remaining icons to the project icon component.