Paths

Table of Contentst

Differential D3393

[landing] Reintroduce hover styling for `Header` nav links
ClosedPublic
Actions

Authored by atul on Mar 9 2022, 5:10 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 2, 1:37 AM

	Unknown Object (File)
	Sat, Feb 1, 10:16 AM

	Unknown Object (File)
	Sat, Feb 1, 10:16 AM

	Unknown Object (File)
	Tue, Jan 28, 4:34 AM

	Unknown Object (File)
	Mon, Jan 27, 8:45 AM

	Unknown Object (File)
	Jan 8 2025, 10:58 AM

	Unknown Object (File)
	Jan 8 2025, 10:33 AM

	Unknown Object (File)
	Jan 3 2025, 9:56 AM

Subscribers

Details

Reviewers

• jacek
varun
• benschac
tomek

Commits

rCOMMba52e334ec4f: [landing] Reintroduce hover styling for `Header` nav links

Summary

Bring back hover styling for Header nav links

Test Plan

Here's how it looks:

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Mar 9 2022, 5:10 PM

Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptMar 9 2022, 5:10 PM

atul added inline comments.Mar 9 2022, 5:12 PM

landing/header.react.js
25 ↗	(On Diff #10256)	I don't think we should change `fontWeight` when a tab becomes active. It causes the text to shift around ever so slightly and it looks kind of tacky/unsettling. Happy to revert this change if there's disagreement.

atul published this revision for review.Mar 9 2022, 5:13 PM

atul edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B7274: Diff 10256.Mar 9 2022, 5:15 PM

tomek accepted this revision.Mar 10 2022, 2:15 AM

tomek added inline comments.

landing/header.react.js
25 ↗	(On Diff #10256)	Agree. If we want to have this effect, we can take a look at `text-shadow`

This revision is now accepted and ready to land.Mar 10 2022, 2:15 AM

If we want to have this effect, we can take a look at text-shadow

Oh nice, this looks neat.. I'll take a look

rebase before landing

This revision was landed with ongoing or failed builds.Mar 10 2022, 9:31 AM

Closed by commit rCOMMba52e334ec4f: [landing] Reintroduce hover styling for `Header` nav links (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMba52e334ec4f: [landing] Reintroduce hover styling for `Header` nav links.

Harbormaster completed remote builds in B7283: Diff 10270.Mar 10 2022, 9:33 AM

Revision Contents
Changeset List

Path

Size

landing/

10 lines

header.react.js

1 line

Diff 10271

landing/header.css

Loading...

landing/header.react.js

Loading...