Page MenuHomePhabricator
Differential D3394

[landing] Reintroduce hover styling for `Request Access` button
AbandonedPublic
Actions

Authored by atul on Mar 9 2022, 5:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 19, 8:38 PM
Unknown Object (File)
Wed, Jan 15, 4:53 PM
Unknown Object (File)
Wed, Jan 15, 4:53 PM
Unknown Object (File)
Wed, Jan 15, 4:52 PM
Unknown Object (File)
Wed, Jan 15, 4:51 PM
Unknown Object (File)
Fri, Dec 27, 9:36 AM
Unknown Object (File)
Fri, Dec 27, 9:36 AM
Unknown Object (File)
Fri, Dec 27, 9:36 AM
View All Files
Subscribers
• adrian
ashoat
• karol

Details

Reviewers
• jacek
• benschac
tomek
varun
ashoat
Summary

Bring back hover styling for Request Access button

Test Plan

Here's how it looks:

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Mar 9 2022, 5:25 PM
Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptMar 9 2022, 5:25 PM
atul edited the test plan for this revision. (Show Details)Mar 9 2022, 5:25 PM
atul updated this revision to Diff 10258.Mar 9 2022, 5:26 PM

use the css variables since they're there

Harbormaster completed remote builds in B7275: Diff 10257.Mar 9 2022, 5:30 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 9 2022, 5:34 PM
Harbormaster failed remote builds in B7276: Diff 10258!
atul requested review of this revision.Mar 9 2022, 9:08 PM
atul added inline comments.
landing/button.css
18

Went with 300ms over 150ms on purpose because I think it looked better in this context, and is what it was before

tomek accepted this revision.EditedMar 10 2022, 2:18 AM
tomek added a reviewer: ashoat.

For me it looks ok, but having an effect where the colors are inversed sounds a bit extreme. Usually hover effects make background color slightly darker / lighter.

There's also a build error on Android, but I bet it is unrelated.

• benschac added a comment.Mar 10 2022, 10:44 AM

I also think this color transition is a bit aggressive. I assume @ashoat is okay with the user experience.

• benschac accepted this revision.Mar 10 2022, 10:45 AM
ashoat requested changes to this revision.Mar 10 2022, 8:10 PM

The color transition does seem intense, can we make that more understated?

By the way, is this the button in the upper right that is getting replaced by moving the email field? If so it's probably not worth spending too much time on it... feel free to re-request review.

This revision now requires changes to proceed.Mar 10 2022, 8:10 PM
atul added a comment.Mar 10 2022, 9:53 PM

By the way, is this the button in the upper right that is getting replaced by moving the email field? If so it's probably not worth spending too much time on it... feel free to re-request review.

Yeah, the button gets removed entirely in D3402. I'll just abandon this diff

atul abandoned this revision.Mar 11 2022, 6:36 AM

We don't need this, button is gonna go anyway

Revision Contents
Changeset List

PathSize
landing/
6 lines

Diff 10258

View Options

landing/button.css

Loading...