component
ClosedPublic
Actions

Authored by • benschac on Mar 14 2022, 12:01 PM.

Details

Reviewers

atul
• jacek
tomek

Commits

rCOMMfc8ff7de1bbc: [web] [refactor] change input buttons to <Button /> component

Summary

Replace all input elements that are submit buttons with HTML Button components. Right now all of the styling is still very off. We should use button elements and our button component in general.

before:

Image 2022-03-14 at 2.09.10 PM.jpg (918×1 px, 160 KB)

after:

Image 2022-03-14 at 2.10.57 PM.jpg (740×1 px, 86 KB)

danger:

Image 2022-03-14 at 3.09.55 PM.jpg (704×1 px, 63 KB)

gif:

Screen Recording 2022-03-14 at 02.40.19 PM.gif (377×653 px, 199 KB)

Test Plan

Make sure functionality still works. I tested the button elements and they all seem to be working.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• benschac created this revision.Mar 14 2022, 12:01 PM

Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 14 2022, 12:01 PM

• benschac added a child revision: D3288: [web] [fix] remove border-radius in input type="submit".Mar 14 2022, 12:02 PM

• benschac edited the summary of this revision. (Show Details)Mar 14 2022, 12:05 PM

Harbormaster completed remote builds in B7356: Diff 10357.Mar 14 2022, 12:06 PM

• benschac requested review of this revision.Mar 14 2022, 12:06 PM

add danger variant to delete

• benschac edited the summary of this revision. (Show Details)Mar 14 2022, 12:10 PM

Harbormaster completed remote builds in B7357: Diff 10358.Mar 14 2022, 12:14 PM

• benschac edited the summary of this revision. (Show Details)Mar 14 2022, 12:14 PM

• benschac added reviewers: • jacek, tomek.

• benschac edited the summary of this revision. (Show Details)

tomek accepted this revision.Mar 15 2022, 11:34 AM

tomek added inline comments.

web/modals/threads/thread-settings-modal.react.js
474 ↗	(On Diff #10358)	Is there a way to choose a type which doesn't need to be modified when changing element type? We're not using anything input or button specific, so maybe `SyntheticEvent<HTMLElement>`?