Interpolate from 16px to 24px for width of 320px to 1850px.
Details
Details
Continues to look as expected:
(towards end)
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- landmarch14 (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Looks ok, but not sure what is the relation to other diffs. We had a diff D3392 which limits the text to two lines, but in the video there's a moment where the text has 3 lines.
| landing/footer.css | ||
|---|---|---|
| 47 |
| |
| 47 | Could you add this (or something like it) as a comment here? | |
Comment Actions
Looks ok, but not sure what is the relation to other diffs. We had a diff D3392 which limits the text to two lines, but in the video there's a moment where the text has 3 lines. (@palys-swm)
I rebased such that the two-line diff is at the end of the stack so that moment in the video isn't a surprise.
Basically re-ordered the commits to:
- Fix up all of the existing "fluid" text after removing the clamp() from root (html css selector)
- Make the changes necessary to support the SubscriptionForm being included in the hero (D3392)
| landing/footer.css | ||
|---|---|---|
| 47 | Yeah, I can add comments to all of these that translate the font-sizes (in px) we want to interpolate over the widths (in px) and then convert them to rem units. Would totally link the CSS Tricks article, but I don't know if the links are "stable" the way StackOverflow ones are. | |
| 47 | I'll do this in a separate diff just to land these. | |