[web] Directly render code that is no longer conditional
ClosedPublic
Actions

Authored by tomek on Mar 21 2022, 3:59 AM.

Details

Reviewers

• benschac
atul
• jacek

Commits

rCOMM7d9fa2130834: [web] Directly render code that is no longer conditional

Summary

Simplify the code by directly rendering instead of first assigning to a variable

Depends on D3473

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Mar 21 2022, 3:59 AM

Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptMar 21 2022, 3:59 AM

tomek added a child revision: D3475: [web] Update password modal copy.Mar 21 2022, 4:01 AM

Harbormaster completed remote builds in B7502: Diff 10558.Mar 21 2022, 4:07 AM

tomek requested review of this revision.Mar 21 2022, 4:07 AM

Could you add a screenshot here? Both with the button and error state?

This revision now requires changes to proceed.Mar 21 2022, 6:59 AM

In D3474#94468, @benschac wrote:

Could you add a screenshot here? Both with the button and error state?

Added the screenshots with the final state in the summary

tomek added 1 blocking reviewer(s): atul.Mar 21 2022, 9:20 AM

• benschac accepted this revision.Mar 22 2022, 5:57 AM

Makes sense!

This revision is now accepted and ready to land.Mar 22 2022, 1:29 PM

Rebase

Harbormaster completed remote builds in B7546: Diff 10615.Mar 23 2022, 8:40 AM

Closed by commit rCOMM7d9fa2130834: [web] Directly render code that is no longer conditional (authored by tomek). · Explain WhyMar 28 2022, 6:19 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM7d9fa2130834: [web] Directly render code that is no longer conditional.

Revision Contents
Changeset List

Path

Size

web/

settings/

password-change-modal.js

74 lines

Diff 10558

View Options

web/settings/password-change-modal.js

[web] Directly render code that is no longer conditionalClosedPublicActions