Noticed width of Input in LoginForm was behaving weirdly. Found this: https://stackoverflow.com/a/628912, and it seems like box-sizing: border-box is what we want for the Input component.
Details
Details
Input looks right in the context of LoginForm. I will look at other instances of Input in web to make sure that things continue to look as expected before landing.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
cc @benschac I think you probably have the most context on this sort of CSS thing, so wondering what you think of making this change?
Comment Actions
Normally the kind of thing I'd apply to every element in a CSS reset or something similar. Because we don't have a reset for web doing something like this:
*, *:before, *:after {
box-sizing: border-box;
}Would probably change the layout pretty dramatically. Makes sense why input fields were looking weird.
Comment Actions
Makes sense to me. Agree that applying it in a CSS reset would be better, but I don't think we can prioritize that right now – I imagine there would be a lot of "fallout" to a change like that