Page MenuHomePhabricator
Differential D3503

[web] [refactor] thread light selected and hover color classes
AbandonedPublic
Actions

Authored by • benschac on Mar 23 2022, 12:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 21, 7:13 AM
Unknown Object (File)
Sat, Apr 19, 1:52 PM
Unknown Object (File)
Sat, Apr 19, 5:03 AM
Unknown Object (File)
Fri, Apr 18, 5:22 AM
Unknown Object (File)
Fri, Apr 18, 4:07 AM
Unknown Object (File)
Tue, Apr 8, 8:23 AM
Unknown Object (File)
Tue, Apr 1, 1:24 AM
Unknown Object (File)
Mar 11 2025, 8:44 AM
View All Files
Subscribers
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
tomek
• jacek
Summary

same functionality, make css classes consistent to further refactor

Screen Recording 2022-03-23 at 02.55.21 PM.gif (542×1 px, 1 MB)

Test Plan

hover, selected and non hovered message previews look the same

Diff Detail

Repository
rCOMM Comm
Branch
fix-hover-background-color
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
web/
chat/
4 lines
2 lines

Diff 10626

View Options

web/chat/chat-thread-list.css

Show All 27 Lines
import { import {
fullStateSyncActionType, fullStateSyncActionType,
incrementalStateSyncActionType, incrementalStateSyncActionType,
} from '../types/socket-types.js'; } from '../types/socket-types.js';
import { updateTypes } from '../types/update-types-enum.js'; import { updateTypes } from '../types/update-types-enum.js';
import { processUpdatesActionType } from '../types/update-types.js'; import { processUpdatesActionType } from '../types/update-types.js';
import type { CurrentUserInfo, UserStore } from '../types/user-types.js'; import type { CurrentUserInfo, UserStore } from '../types/user-types.js';
import { setNewSessionActionType } from '../utils/action-utils.js'; import { setNewSessionActionType } from '../utils/action-utils.js';
import { getMessageForException } from '../utils/errors.js';
import { assertObjectsAreEqual } from '../utils/objects.js';
function reduceCurrentUserInfo( function reduceCurrentUserInfo(
state: ?CurrentUserInfo, state: ?CurrentUserInfo,
action: BaseAction, action: BaseAction,
): ?CurrentUserInfo { ): ?CurrentUserInfo {
if ( if (
action.type === logInActionTypes.success || action.type === logInActionTypes.success ||
action.type === siweAuthActionTypes.success || action.type === siweAuthActionTypes.success ||
▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Lines if (state?.settings) {
}; };
} }
} else if (action.type === resetUserStateActionType) { } else if (action.type === resetUserStateActionType) {
state = state && state.anonymous ? state : null; state = state && state.anonymous ? state : null;
} }
return state; return state;
} }
// eslint-disable-next-line no-unused-vars
function assertUserStoresAreEqual(
processedUserStore: UserStore,
expectedUserStore: UserStore,
location: string,
onStateDifference: (message: string) => mixed,
) {
try {
assertObjectsAreEqual(
processedUserStore,
expectedUserStore,
`UserStore - ${location}`,
);
} catch (e) {
const message = `Error processing UserStore ops ${
kamilAuthorUnsubmitted
Done
Inline Actions

UserStore here is probably redundant (look at screenshots)

kamil: `UserStore` here is probably redundant (look at screenshots)
getMessageForException(e) ?? '{no exception message}'
}`;
onStateDifference(message);
}
}
function reduceUserInfos( function reduceUserInfos(
state: UserStore, state: UserStore,
action: BaseAction, action: BaseAction,
// eslint-disable-next-line no-unused-vars
kamilAuthorUnsubmitted
Done
Inline Actions

I'll remove those in the next diff (here and line 125)

kamil: I'll remove those in the next diff (here and line 125)
onStateDifference: (message: string) => mixed,
): [UserStore, $ReadOnlyArray<UserInconsistencyReportCreationRequest>] { ): [UserStore, $ReadOnlyArray<UserInconsistencyReportCreationRequest>] {
if ( if (
action.type === joinThreadActionTypes.success || action.type === joinThreadActionTypes.success ||
action.type === newThreadActionTypes.success action.type === newThreadActionTypes.success
) { ) {
const newUserInfos = _keyBy(userInfo => userInfo.id)( const newUserInfos = _keyBy(userInfo => userInfo.id)(
action.payload.userInfos, action.payload.userInfos,
); );
▲ Show 20 Lines • Show All 121 Lines • Show Last 20 Lines
View Options

web/chat/message-preview.react.js

Show All 27 Lines
import { import {
fullStateSyncActionType, fullStateSyncActionType,
incrementalStateSyncActionType, incrementalStateSyncActionType,
} from '../types/socket-types.js'; } from '../types/socket-types.js';
import { updateTypes } from '../types/update-types-enum.js'; import { updateTypes } from '../types/update-types-enum.js';
import { processUpdatesActionType } from '../types/update-types.js'; import { processUpdatesActionType } from '../types/update-types.js';
import type { CurrentUserInfo, UserStore } from '../types/user-types.js'; import type { CurrentUserInfo, UserStore } from '../types/user-types.js';
import { setNewSessionActionType } from '../utils/action-utils.js'; import { setNewSessionActionType } from '../utils/action-utils.js';
import { getMessageForException } from '../utils/errors.js';
import { assertObjectsAreEqual } from '../utils/objects.js';
function reduceCurrentUserInfo( function reduceCurrentUserInfo(
state: ?CurrentUserInfo, state: ?CurrentUserInfo,
action: BaseAction, action: BaseAction,
): ?CurrentUserInfo { ): ?CurrentUserInfo {
if ( if (
action.type === logInActionTypes.success || action.type === logInActionTypes.success ||
action.type === siweAuthActionTypes.success || action.type === siweAuthActionTypes.success ||
▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Lines if (state?.settings) {
}; };
} }
} else if (action.type === resetUserStateActionType) { } else if (action.type === resetUserStateActionType) {
state = state && state.anonymous ? state : null; state = state && state.anonymous ? state : null;
} }
return state; return state;
} }
// eslint-disable-next-line no-unused-vars
function assertUserStoresAreEqual(
processedUserStore: UserStore,
expectedUserStore: UserStore,
location: string,
onStateDifference: (message: string) => mixed,
) {
try {
assertObjectsAreEqual(
processedUserStore,
expectedUserStore,
`UserStore - ${location}`,
);
} catch (e) {
const message = `Error processing UserStore ops ${
kamilAuthorUnsubmitted
Done
Inline Actions

UserStore here is probably redundant (look at screenshots)

kamil: `UserStore` here is probably redundant (look at screenshots)
getMessageForException(e) ?? '{no exception message}'
}`;
onStateDifference(message);
}
}
function reduceUserInfos( function reduceUserInfos(
state: UserStore, state: UserStore,
action: BaseAction, action: BaseAction,
// eslint-disable-next-line no-unused-vars
kamilAuthorUnsubmitted
Done
Inline Actions

I'll remove those in the next diff (here and line 125)

kamil: I'll remove those in the next diff (here and line 125)
onStateDifference: (message: string) => mixed,
): [UserStore, $ReadOnlyArray<UserInconsistencyReportCreationRequest>] { ): [UserStore, $ReadOnlyArray<UserInconsistencyReportCreationRequest>] {
if ( if (
action.type === joinThreadActionTypes.success || action.type === joinThreadActionTypes.success ||
action.type === newThreadActionTypes.success action.type === newThreadActionTypes.success
) { ) {
const newUserInfos = _keyBy(userInfo => userInfo.id)( const newUserInfos = _keyBy(userInfo => userInfo.id)(
action.payload.userInfos, action.payload.userInfos,
); );
▲ Show 20 Lines • Show All 121 Lines • Show Last 20 Lines