Page MenuHomePhabricator
Differential D3504

[web] [refactor] destructure props in message preview component
ClosedPublic
Actions

Authored by • benschac on Mar 23 2022, 12:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 4:16 AM
Unknown Object (File)
Tue, Dec 17, 4:16 AM
Unknown Object (File)
Mon, Dec 16, 5:17 PM
Unknown Object (File)
Nov 8 2024, 8:09 PM
Unknown Object (File)
Nov 2 2024, 8:04 AM
Unknown Object (File)
Oct 7 2024, 4:46 AM
Unknown Object (File)
Oct 7 2024, 4:46 AM
Unknown Object (File)
Oct 7 2024, 4:46 AM
View All Files
Subscribers
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
• jacek
tomek
Commits
rCOMMdd249a8d6049: [web] [refactor] destructure props in message preview component
Summary

no functionality changes. Just keeping the component consistent with the rest of the codebase and destructuring props.

Test Plan

message preview component still works like it did before changes.

Diff Detail

Repository
rCOMM Comm
Branch
fix-hover-background-color
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• benschac created this revision.Mar 23 2022, 12:13 PM
Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 23 2022, 12:13 PM
• benschac added a parent revision: D3503: [web] [refactor] thread light selected and hover color classes.Mar 23 2022, 12:14 PM
Harbormaster completed remote builds in B7556: Diff 10627.Mar 23 2022, 12:18 PM
• benschac requested review of this revision.Mar 23 2022, 12:18 PM
• benschac added a child revision: D3505: [web] [refactor] message preview styles solidified into one ternary statement.Mar 23 2022, 12:26 PM
• benschac added reviewers: • jacek, tomek.Mar 23 2022, 1:54 PM
tomek accepted this revision.Mar 25 2022, 3:36 AM
tomek added inline comments.
web/chat/message-preview.react.js
24–25

If we're always destructuring in the first statement, we can as well destructure as a function argument. What do you think about taking this approach in the future?

36

messageInfoProps doesn't sound like a useful name... maybe originalMessageInfo?

This revision is now accepted and ready to land.Mar 25 2022, 3:36 AM
• benschac updated this revision to Diff 10691.Mar 25 2022, 8:01 AM

diff review. update name

• benschac added inline comments.Mar 25 2022, 8:04 AM
web/chat/message-preview.react.js
24–25

We've stuck with the current pattern pretty consistently in the codebase. I'm for sticking with the current convention. IMO i like it more.

If we as a team want to change it lets agree and then codemod it everywhere: https://github.com/facebookarchive/codemod. Or whatever has replaced codemod.

Harbormaster completed remote builds in B7615: Diff 10691.Mar 25 2022, 8:59 AM
Closed by commit rCOMMdd249a8d6049: [web] [refactor] destructure props in message preview component (authored by • benschac). · Explain WhyMar 25 2022, 9:57 AM
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMMdd249a8d6049: [web] [refactor] destructure props in message preview component.

Revision Contents
Changeset List

PathSize
web/
chat/
18 lines

Diff 10627

View Options

web/chat/message-preview.react.js

Loading...