Paths

Table of Contentst

-
web/chat/
-
chat/
2/4
chat-thread-list.css
2/4
message-preview.react.js

Differential D3505

[web] [refactor] message preview styles solidified into one ternary statement
ClosedPublic
Actions

Authored by • benschac on Mar 23 2022, 12:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Mar 31, 5:10 PM

	Unknown Object (File)
	Mon, Mar 31, 4:36 PM

	Unknown Object (File)
	Mon, Mar 31, 2:29 PM

	Unknown Object (File)
	Mon, Mar 31, 1:09 PM

	Unknown Object (File)
	Sun, Mar 30, 12:39 PM

	Unknown Object (File)
	Sat, Mar 29, 4:50 PM

	Unknown Object (File)
	Sat, Mar 29, 9:11 AM

	Unknown Object (File)
	Mon, Mar 17, 9:59 AM

Subscribers

Details

Reviewers

atul
• jacek
tomek
ashoat

Commits

rCOMMec5704f78a30: [web] [refactor] message preview styles solidified into one ternary statement

Summary

move styles into a single call

Test Plan

click and hover about chat thread list items. Functionality should be the same

Diff Detail

Repository

Branch

arcpatch-D3505

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Mar 23 2022, 12:20 PM

Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 23 2022, 12:20 PM

Harbormaster completed remote builds in B7557: Diff 10628.Mar 23 2022, 12:25 PM

• benschac requested review of this revision.Mar 23 2022, 12:25 PM

• benschac added a parent revision: D3504: [web] [refactor] destructure props in message preview component.Mar 23 2022, 12:26 PM

• benschac added a child revision: D3506: [web] [refactor] simplify username logic in message preview.Mar 23 2022, 12:34 PM

remove array

Harbormaster completed remote builds in B7564: Diff 10635.Mar 23 2022, 1:33 PM

• benschac added reviewers: • jacek, tomek.Mar 23 2022, 1:54 PM

• benschac mentioned this in D3500: [web] [refactor] css color should be white.Mar 24 2022, 8:53 AM

rename classes from color to actions

Harbormaster completed remote builds in B7596: Diff 10667.Mar 24 2022, 9:51 AM

ashoat accepted this revision.Mar 24 2022, 6:04 PM

This revision is now accepted and ready to land.Mar 24 2022, 6:04 PM

tomek accepted this revision.Mar 25 2022, 3:06 AM

css['white'] project for this string before landing.

In D3505#95835, @benschac wrote:

css['white'] project for this string before landing.

searched the project and didn't see it anywhere.

rebase

This revision was landed with ongoing or failed builds.Mar 25 2022, 10:20 AM

Closed by commit rCOMMec5704f78a30: [web] [refactor] message preview styles solidified into one ternary statement (authored by • benschac). · Explain Why

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMMec5704f78a30: [web] [refactor] message preview styles solidified into one ternary statement.

I should have waited for the CI to finish. Sorry everyone.

Harbormaster completed remote builds in B7621: Diff 10702.Mar 25 2022, 10:23 AM

Revision Contents
Changeset List

Path

Size

web/

chat/

chat-thread-list.css

8 lines

message-preview.react.js

8 lines

Diff 10702

web/chat/chat-thread-list.css

This file was added.

				div.containerViewerLiked {
				padding: 4px;
				border-radius: 4px;
				background-color: var(--shades-black-80);
				}

				div.container:hover {
				cursor: pointer;
				}
				tomekUnsubmitted Not Done Inline Actions For other tooltip actions we don't need to manually set this style. Can we use the mechanism we already have, or are there any reasons for not doing so? tomek: For other tooltip actions we don't need to manually set this style. Can we use the mechanism we…
				ginsuAuthorUnsubmitted Done Inline Actions I believe the other icons don't need to set this style because it is built into `IcomoonReact`. When I switched the Like action tooltip button with one of the icons the hover style just works out of the box. Wondering if @atul has more context since he is pretty familiar with the icons stuff ginsu: I believe the other icons don't need to set this style because it is built into `IcomoonReact`.
				tomekUnsubmitted Not Done Inline Actions It wouldn't make too much sense for `Icomoon` to provide hover effects for icons because they could be used in other places - not only as buttons. It seems like the style on hover is applied in `message-tooltip.css` div.messageActionButtons svg:hover { cursor: pointer; color: var(--fg); } so it should be enough to apply this style also to the new button. tomek: It wouldn't make too much sense for `Icomoon` to provide hover effects for icons because they…
				ginsuAuthorUnsubmitted Done Inline Actions Ahhhhh that makes sense, thank you for clarifying, I will make the necessary changes ginsu: Ahhhhh that makes sense, thank you for clarifying, I will make the necessary changes

web/chat/message-preview.react.js

This file was added.

				div.containerViewerLiked {
				padding: 4px;
				border-radius: 4px;
				background-color: var(--shades-black-80);
				}

				div.container:hover {
				cursor: pointer;
				}
				tomekUnsubmitted Not Done Inline Actions For other tooltip actions we don't need to manually set this style. Can we use the mechanism we already have, or are there any reasons for not doing so? tomek: For other tooltip actions we don't need to manually set this style. Can we use the mechanism we…
				ginsuAuthorUnsubmitted Done Inline Actions I believe the other icons don't need to set this style because it is built into `IcomoonReact`. When I switched the Like action tooltip button with one of the icons the hover style just works out of the box. Wondering if @atul has more context since he is pretty familiar with the icons stuff ginsu: I believe the other icons don't need to set this style because it is built into `IcomoonReact`.
				tomekUnsubmitted Not Done Inline Actions It wouldn't make too much sense for `Icomoon` to provide hover effects for icons because they could be used in other places - not only as buttons. It seems like the style on hover is applied in `message-tooltip.css` div.messageActionButtons svg:hover { cursor: pointer; color: var(--fg); } so it should be enough to apply this style also to the new button. tomek: It wouldn't make too much sense for `Icomoon` to provide hover effects for icons because they…
				ginsuAuthorUnsubmitted Done Inline Actions Ahhhhh that makes sense, thank you for clarifying, I will make the necessary changes ginsu: Ahhhhh that makes sense, thank you for clarifying, I will make the necessary changes