[web] [refactor] update message info ternary to if else, to match codebase convention
AbandonedPublic
Actions

Authored by • benschac on Mar 23 2022, 1:14 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jan 15, 5:17 PM

	Unknown Object (File)
	Sun, Jan 12, 7:30 AM

	Unknown Object (File)
	Thu, Jan 9, 6:44 PM

	Unknown Object (File)
	Thu, Jan 9, 9:43 AM

	Unknown Object (File)
	Thu, Jan 9, 9:42 AM

	Unknown Object (File)
	Thu, Jan 9, 9:22 AM

	Unknown Object (File)
	Thu, Jan 9, 9:15 AM

	Unknown Object (File)
	Dec 5 2024, 12:10 PM

Subscribers

Details

Reviewers

atul
• jacek
tomek
ashoat

Summary

we normally don't have large ternary statements like this, switching to if else.

Test Plan

send messages back and forth. Make sure text is what you would expect.

Diff Detail

Repository

rCOMM Comm

Branch

fix-hover-background-color

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Mar 23 2022, 1:14 PM

Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 23 2022, 1:14 PM

• benschac added a parent revision: D3508: [web] [refactor] move hasUsername logic to variable.Mar 23 2022, 1:15 PM

Harbormaster completed remote builds in B7563: Diff 10634.Mar 23 2022, 1:19 PM

• benschac requested review of this revision.Mar 23 2022, 1:19 PM

• benschac added reviewers: • jacek, tomek.Mar 23 2022, 1:56 PM

This is fine as a ternary, in my opinion. See my comment here

This revision now requires changes to proceed.Mar 23 2022, 8:42 PM

Okay, it seemed like a bit much. I'll abandon this diff.

In D3509#95333, @ashoat wrote:

This is fine as a ternary, in my opinion. See my comment here

https://www.notion.so/commapp/Diff-Review-Rules-addfc3a41b324c7d8ba636dd9dcefeba -- added your comment to the diff review rules.

• benschac abandoned this revision.Mar 24 2022, 6:03 AM

Revision Contents
Changeset List

Path

Size

web/

chat/

message-preview.react.js

11 lines

Diff 10634

View Options

web/chat/message-preview.react.js

[web] [refactor] update message info ternary to if else, to match codebase conventionAbandonedPublicActions